From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2998871AbdDZKzn (ORCPT ); Wed, 26 Apr 2017 06:55:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:24397 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2998728AbdDZKzb (ORCPT ); Wed, 26 Apr 2017 06:55:31 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com D27D09D0C6 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=dhowells@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com D27D09D0C6 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20170422192743.GA17005@altlinux.org> References: <20170422192743.GA17005@altlinux.org> To: "Dmitry V. Levin" Cc: dhowells@redhat.com, Al Viro , linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, mtk.manpages@gmail.com Subject: Re: [PATCH] uapi: remove false assertion that statx_timestamp.tv_nsec can be negative MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <13743.1493204125.1@warthog.procyon.org.uk> Date: Wed, 26 Apr 2017 11:55:25 +0100 Message-ID: <13744.1493204125@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 26 Apr 2017 10:55:28 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dmitry V. Levin wrote: > remove false assertion It's not a false assertion. I defined the statx interface that way. > The best fix for this source of confusion is to change the type > of struct statx_timestamp.tv_nsec from __s32 to __u32 . Okay, if we're going to do the comment change, we should effect the type change also. Do you want to update your patch? David