From: Oleksandr Kravchenko <x0199363@ti.com>
To: <jic23@cam.ac.uk>
Cc: <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Oleksandr Kravchenko <o.v.kravchenko@globallogic.com>
Subject: [PATCH] iio: core: Avoid double minus in sysfs output
Date: Mon, 22 Jul 2013 14:16:03 +0300 [thread overview]
Message-ID: <1374491763-16149-1-git-send-email-x0199363@ti.com> (raw)
From: Oleksandr Kravchenko <o.v.kravchenko@globallogic.com>
This patch fixes the issue with double minus in output when
reading channels from sysfs for IIO_VAL_INT_PLUS_MICRO and
IIO_VAL_INT_PLUS_NANO cases. Until this patch if val and val2
both are negatives output string contains "--" before
digits. It is result of "-%d..." in sprintf() format.
Signed-off-by: Oleksandr Kravchenko <o.v.kravchenko@globallogic.com>
---
drivers/iio/industrialio-core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
index d56d122..97f0297 100644
--- a/drivers/iio/industrialio-core.c
+++ b/drivers/iio/industrialio-core.c
@@ -383,14 +383,14 @@ static ssize_t iio_read_channel_info(struct device *dev,
scale_db = true;
case IIO_VAL_INT_PLUS_MICRO:
if (val2 < 0)
- return sprintf(buf, "-%d.%06u%s\n", val, -val2,
+ return sprintf(buf, "-%ld.%06u%s\n", abs(val), -val2,
scale_db ? " dB" : "");
else
return sprintf(buf, "%d.%06u%s\n", val, val2,
scale_db ? " dB" : "");
case IIO_VAL_INT_PLUS_NANO:
if (val2 < 0)
- return sprintf(buf, "-%d.%09u\n", val, -val2);
+ return sprintf(buf, "-%ld.%09u\n", abs(val), -val2);
else
return sprintf(buf, "%d.%09u\n", val, val2);
case IIO_VAL_FRACTIONAL:
--
1.7.9.5
next reply other threads:[~2013-07-22 11:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-22 11:16 Oleksandr Kravchenko [this message]
2013-07-27 11:51 ` Jonathan Cameron
-- strict thread matches above, loose matches on Subject: below --
2013-07-22 10:57 Oleksandr Kravchenko
2013-07-18 15:47 Oleksandr Kravchenko
2013-07-18 16:24 ` Lars-Peter Clausen
2013-07-19 6:15 ` Oleksandr Kravchenko
2013-07-19 21:06 ` Jonathan Cameron
2013-07-22 10:51 ` Oleksandr Kravchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1374491763-16149-1-git-send-email-x0199363@ti.com \
--to=x0199363@ti.com \
--cc=jic23@cam.ac.uk \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=o.v.kravchenko@globallogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®