mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: acme@infradead.org
Cc: mingo@kernel.org, linux-kernel@vger.kernel.org,
	Andi Kleen <ak@linux.intel.com>
Subject: [PATCH 1/2] tools, perf: Add a precise event qualifier v2
Date: Mon, 22 Jul 2013 06:52:17 -0700	[thread overview]
Message-ID: <1374501138-13496-1-git-send-email-andi@firstfloor.org> (raw)

From: Andi Kleen <ak@linux.intel.com>

Add a precise qualifier, like cpu/event=0x3c,precise=1/

This is needed so that the kernel can request enabling PEBS
on specific events. This is useful for mem-loads/mem-stores

Currently you have to known that mem-loads is a PEBS event
and use

perf record -e cpu/mem-loads/p ...

With this patch we can export the PEBSness of events in sysfs and
then allow

perf record -e cpu/mem-loads/ ...

or with the additional patch to automatically add cpu//

perf record -e mem-loads ...

Also useful for some other events added in later patches.

v2: Allow 3 as value
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
 tools/perf/util/parse-events.c | 6 ++++++
 tools/perf/util/parse-events.h | 1 +
 tools/perf/util/parse-events.l | 1 +
 3 files changed, 8 insertions(+)

diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
index 995fc25..34f1470 100644
--- a/tools/perf/util/parse-events.c
+++ b/tools/perf/util/parse-events.c
@@ -568,6 +568,12 @@ do {								\
 	case PARSE_EVENTS__TERM_TYPE_NAME:
 		CHECK_TYPE_VAL(STR);
 		break;
+	case PARSE_EVENTS__TERM_TYPE_PRECISE:
+		CHECK_TYPE_VAL(NUM);
+		if ((unsigned)term->val.num > 3)
+			return -EINVAL;
+		attr->precise_ip = term->val.num;
+		break;
 	default:
 		return -EINVAL;
 	}
diff --git a/tools/perf/util/parse-events.h b/tools/perf/util/parse-events.h
index 8a48593..13d7c66 100644
--- a/tools/perf/util/parse-events.h
+++ b/tools/perf/util/parse-events.h
@@ -48,6 +48,7 @@ enum {
 	PARSE_EVENTS__TERM_TYPE_NAME,
 	PARSE_EVENTS__TERM_TYPE_SAMPLE_PERIOD,
 	PARSE_EVENTS__TERM_TYPE_BRANCH_SAMPLE_TYPE,
+	PARSE_EVENTS__TERM_TYPE_PRECISE,
 };
 
 struct parse_events_term {
diff --git a/tools/perf/util/parse-events.l b/tools/perf/util/parse-events.l
index e9d1134..32a9000 100644
--- a/tools/perf/util/parse-events.l
+++ b/tools/perf/util/parse-events.l
@@ -169,6 +169,7 @@ period			{ return term(yyscanner, PARSE_EVENTS__TERM_TYPE_SAMPLE_PERIOD); }
 branch_type		{ return term(yyscanner, PARSE_EVENTS__TERM_TYPE_BRANCH_SAMPLE_TYPE); }
 ,			{ return ','; }
 "/"			{ BEGIN(INITIAL); return '/'; }
+precise			{ return term(yyscanner, PARSE_EVENTS__TERM_TYPE_PRECISE); }
 {name_minus}		{ return str(yyscanner, PE_NAME); }
 }
 
-- 
1.8.3.1


             reply	other threads:[~2013-07-22 13:52 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-22 13:52 Andi Kleen [this message]
2013-07-22 13:52 ` [PATCH 2/2] perf, x86: Enable PEBS mode automatically for mem-{loads,stores} v4 Andi Kleen
2013-07-23  5:40 ` [PATCH 1/2] tools, perf: Add a precise event qualifier v2 Vince Weaver
2013-07-23  6:01   ` Andi Kleen
2013-07-23 21:27     ` Vince Weaver
2013-07-23 22:51       ` Andi Kleen
2013-07-24  0:39         ` Sasha Levin
2013-07-24  1:33           ` Andi Kleen
2013-07-24 18:31             ` Vince Weaver
2013-07-24 18:54           ` Vince Weaver
2013-07-24 18:47         ` Vince Weaver
2013-07-24 19:05           ` Andi Kleen
2013-07-26  3:58             ` Vince Weaver
2013-09-12 16:57         ` Ingo Molnar
2013-09-12 17:36           ` Andi Kleen
2013-09-12 17:59             ` Ingo Molnar
2013-09-13  8:56             ` Peter Zijlstra
2013-09-13  9:50               ` Ingo Molnar
2013-09-13 11:29                 ` Peter Zijlstra
2013-09-13 14:31                   ` Vince Weaver
2013-09-13 17:48               ` Andi Kleen
2013-09-12 19:35           ` Vince Weaver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1374501138-13496-1-git-send-email-andi@firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=acme@infradead.org \
    --cc=ak@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome