From: Joe Perches <joe@perches.com>
To: Lilis Iskandar <veeableful@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
tulinizer@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/5] Staging: bcm: LeakyBucket: Fixed spacing/tabing issues
Date: Sat, 27 Jul 2013 18:37:05 -0700 [thread overview]
Message-ID: <1374975425.2075.16.camel@joe-AO722> (raw)
In-Reply-To: <1374953687-14386-1-git-send-email-veeableful@gmail.com>
On Sun, 2013-07-28 at 03:34 +0800, Lilis Iskandar wrote:
> I don't understand what you mean by mentioning "git diff -w".
> Perhaps you can clarify it for me? Sorry :(
$ git diff --help | grep -w -A2 "\-w"
-w, --ignore-all-space
Ignore whitespace when comparing lines. This ignores differences even if one line has whitespace where the other line has none.
It makes sure you are doing only whitespace changes.
Any other changes show up as an actual diff.
You can also compile the changes and make sure
the .o files before and after don't change.
(Something like: assuming a clean tree)
$ cat compare_patch_obj_diffs.sh
#!/bin/bash
if [[ ! -e $1 || ! -f $1 ]]
then
echo "$1 not found"
exit $?
fi
grep -P "^\+\+\+" $1 |
while read file
do
real_file=$(echo $file | cut -f2- -d'/')
if [[ ${real_file:(-2)} == ".c" ]]
then
obj=${real_file%.c}.o
make $obj
mv $obj $obj.old
patch -p1 < $1
make $obj
mv $obj $obj.new
patch -p1 -R < $1
size $obj.old $obj.new
if [[ $2 == "y" ]]
then
objdump -d $obj.old > $obj.old.dmp
objdump -d $obj.new > $obj.new.dmp
diff $obj.old.dmp $obj.new.dmp
rm -f $obj.old.dmp $obj.new.dmp
fi
fi
done
next prev parent reply other threads:[~2013-07-28 1:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-27 19:34 Lilis Iskandar
2013-07-27 19:34 ` [PATCH v2 2/5] Staging: bcm: LeakyBucket: Fixed brace issues Lilis Iskandar
2013-07-27 19:34 ` [PATCH v2 3/5] Staging: bcm: LeakyBucket: Fixed C99 comments Lilis Iskandar
2013-07-27 19:34 ` [PATCH v2 4/5] Staging: bcm: LeakyBucket: Fixed code indent issues Lilis Iskandar
2013-07-27 19:34 ` [PATCH v2 5/5] Staging: bcm: LeakyBucket: Fixed a pointer asterisk placement issue Lilis Iskandar
2013-07-28 1:37 ` Joe Perches [this message]
2013-07-29 18:34 ` [PATCH v2 1/5] Staging: bcm: LeakyBucket: Fixed spacing/tabing issues Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1374975425.2075.16.camel@joe-AO722 \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tulinizer@gmail.com \
--cc=veeableful@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®