From: Eric Dumazet <eric.dumazet@gmail.com>
To: paulmck@linux.vnet.ibm.com
Cc: linux-kernel@vger.kernel.org, john.stultz@linaro.org,
davem@davemloft.net, arnd@arndb.de, mingo@kernel.org,
torvalds@linux-foundation.org
Subject: Re: [PATCH jiffies] Avoid undefined behavior from signed overflow
Date: Sun, 28 Jul 2013 11:46:59 -0700 [thread overview]
Message-ID: <1375037219.3669.34.camel@edumazet-glaptop> (raw)
In-Reply-To: <20130727225828.GA11864@linux.vnet.ibm.com>
On Sat, 2013-07-27 at 15:58 -0700, Paul E. McKenney wrote:
> According to the C standard 3.4.3p3, overflow of a signed integer results
> in undefined behavior. This commit therefore changes the definitions
> of time_after() and time_after_eq() to avoid this undefined behavior.
> The trick is that the subtraction is done using unsigned arithmetic,
> which according to 6.2.5p9 cannot overflow because it is defined as
> modulo arithmetic. This has the added (though admittedly quite small)
> benefit of shortening two lines of code by four characters each.
>
> Note that the C standard considers the cast from signed to
> unsigned to be implementation-defined, see 6.3.1.3p3. However, on a
> two-complement system, an implementation that defines anything other
> than a reinterpretation of the bits is free come to me, and I will be
> happy to act as a witness for its being committed to an insane asylum.
> (Although I have nothing against saturating arithmetic or signals in
> some cases, these things really should not be the default.)
>
> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> Cc: John Stultz <john.stultz@linaro.org>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
>
> diff --git a/include/linux/jiffies.h b/include/linux/jiffies.h
> index 97ba4e7..97967ba 100644
> --- a/include/linux/jiffies.h
> +++ b/include/linux/jiffies.h
> @@ -101,13 +101,13 @@ static inline u64 get_jiffies_64(void)
> #define time_after(a,b) \
> (typecheck(unsigned long, a) && \
> typecheck(unsigned long, b) && \
> - ((long)(b) - (long)(a) < 0))
> + ((long)((b) - (a)) < 0))
> #define time_before(a,b) time_after(b,a)
>
> #define time_after_eq(a,b) \
> (typecheck(unsigned long, a) && \
> typecheck(unsigned long, b) && \
> - ((long)(a) - (long)(b) >= 0))
> + ((long)((a) - (b)) >= 0))
> #define time_before_eq(a,b) time_after_eq(b,a)
>
time_after64() & time_after_eq64() probably need the same.
next prev parent reply other threads:[~2013-07-28 18:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-27 22:58 Paul E. McKenney
2013-07-28 18:46 ` Eric Dumazet [this message]
2013-07-29 2:55 ` Paul E. McKenney
2013-07-29 5:30 ` caf
2013-07-29 13:54 ` Paul E. McKenney
2013-07-29 14:01 ` Kevin Easton
2013-07-29 14:28 ` Paul E. McKenney
2013-08-04 19:16 ` Linus Torvalds
2013-08-04 20:20 ` Paul E. McKenney
2013-08-04 20:23 ` Linus Torvalds
2013-08-04 20:34 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375037219.3669.34.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®