From: Joe Perches <joe@perches.com>
To: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Cc: Andy Whitcroft <apw@canonical.com>, linux-kernel@vger.kernel.org
Subject: Re: Checkpatch error on trace events macros
Date: Mon, 29 Jul 2013 13:02:44 -0700 [thread overview]
Message-ID: <1375128164.2075.53.camel@joe-AO722> (raw)
In-Reply-To: <20130729195201.GC14883@xanatos>
On Mon, 2013-07-29 at 12:52 -0700, Sarah Sharp wrote:
> Hi Andy and Joe,
Hi Sarah.
> Checkpatch is complaining when code adds new trace events macros:
>
> sarah@xanatos:~/git/kernels/xhci$ git am -s ~/Maildir.fetchmail/.to-apply
> Applying: xhci: add traces for debug messages in xhci_address_device()
> ERROR: Macros with complex values should be enclosed in parenthesis
> #86: FILE: drivers/usb/host/xhci-trace.h:15:
> +#define TRACE_SYSTEM xhci-hcd
<shrug>
I think these are suboptimal as the files should use
underscores rather than dashes.
checkpatch sees this as a subtraction which really
should have parentheses.
> ERROR: Macros with complex values should be enclosed in parenthesis
> #115: FILE: drivers/usb/host/xhci-trace.h:44:
> +#define TRACE_INCLUDE_PATH .
>
> ERROR: Macros with complex values should be enclosed in parenthesis
> #118: FILE: drivers/usb/host/xhci-trace.h:47:
> +#define TRACE_INCLUDE_FILE xhci-trace
Don't expect to checkpatch to be perfect.
It's not.
It's a stupid little tool good for some things
and good for highlighting areas that might need
another look.
Use your judgment about everything it spews.
next prev parent reply other threads:[~2013-07-29 20:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 19:52 Sarah Sharp
2013-07-29 20:02 ` Joe Perches [this message]
2013-07-29 21:23 ` Sarah Sharp
2013-07-29 21:48 ` Joe Perches
2013-07-30 1:30 ` Li Zefan
2013-07-30 1:58 ` Joe Perches
2013-07-30 2:06 ` Li Zefan
2013-07-30 2:36 ` Joe Perches
2013-07-30 3:04 ` Li Zefan
2013-07-30 3:10 ` Joe Perches
2013-07-30 3:25 ` Li Zefan
2013-07-30 18:17 ` [PATCH] checkpatch: Ignore #define TRACE_<foo> macros Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375128164.2075.53.camel@joe-AO722 \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sarah.a.sharp@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®