From: Joe Perches <joe@perches.com>
To: Dave Hansen <dave@sr71.net>, Andrew Morton <akpm@linux-foundation.org>
Cc: Andy Whitcroft <apw@canonical.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: enforce sane perl version
Date: Mon, 29 Jul 2013 13:10:13 -0700 [thread overview]
Message-ID: <1375128613.2075.56.camel@joe-AO722> (raw)
In-Reply-To: <20130729200606.2651EE1E@viggo.jf.intel.com>
On Mon, 2013-07-29 at 13:06 -0700, Dave Hansen wrote:
> From: Dave Hansen <dave.hansen@linux.intel.com>
>
> I got a bug report from a couple of users who said
> checkpatch.pl was broken for them. It was erroring out on
> fairly random lines most commonly with messages like:
>
> Nested quantifiers in regex; marked by <--HERE in m/(\((?:[^\(\)]++ <-- HERE |(?-1))*\))/ at ./checkpatch.pl line 340.
>
> The bug reporter was running a version of perl 5.8 which was
> end-of-lifed in 2008: http://www.cpan.org/src/. Versions of perl
> this old are at _best_ quite untested. At worst, they are crusty
> and known to be completely broken.
>
> If folks have a system _that_ old, then we should have mercy on
> them and give them a half-decent error message rather than fail
> with nutty error messages.
>
> This patch enforces that checkpatch.pl is run with perl 5.10,
> which was end-of-lifed in 2009. The new --ignore-perl-version
> command-line switch will let folks override this if they want.
>
> Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Other than Andrew Morton's (continuing?) use of perl 5.8
I'm fine with this.
Andrew? Time to update your perl version?
next prev parent reply other threads:[~2013-07-29 20:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 20:06 Dave Hansen
2013-07-29 20:10 ` Joe Perches [this message]
2013-07-29 22:52 ` Andrew Morton
2013-07-29 23:01 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375128613.2075.56.camel@joe-AO722 \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=dave@sr71.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®