From: Joe Perches <joe@perches.com>
To: Chen Gang <gang.chen@asianux.com>
Cc: "'Jiri Kosina'" <trivial@kernel.org>,
jaharkes@cs.cmu.edu, coda@cs.cmu.edu,
codalist@TELEMANN.coda.cs.cmu.edu,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH trivial] include/linux/coda.h: remove useless '#else'
Date: Tue, 30 Jul 2013 05:29:40 -0700 [thread overview]
Message-ID: <1375187380.2075.111.camel@joe-AO722> (raw)
In-Reply-To: <51F76B7D.2090602@asianux.com>
On Tue, 2013-07-30 at 15:30 +0800, Chen Gang wrote:
> '#else' is useless, need remove.
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
> include/linux/coda.h | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/coda.h b/include/linux/coda.h
> index cff544f..d30209b 100644
> --- a/include/linux/coda.h
> +++ b/include/linux/coda.h
> @@ -60,7 +60,6 @@ Mellon the rights to redistribute these changes without encumbrance.
>
> #if defined(__linux__)
> typedef unsigned long long u_quad_t;
> -#else
> #endif
> #include <uapi/linux/coda.h>
> #endif
Why have the #if at all?
next prev parent reply other threads:[~2013-07-30 12:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-30 7:30 Chen Gang
2013-07-30 10:38 ` Jiri Kosina
2013-07-31 0:06 ` Chen Gang
2013-07-30 12:29 ` Joe Perches [this message]
2013-07-31 1:44 ` Chen Gang
2013-07-31 1:53 ` Chen Gang
2013-07-31 3:16 ` Chen Gang F T
2013-08-05 0:24 ` Chen Gang
2013-08-05 1:21 ` Joe Perches
2013-08-05 1:53 ` Chen Gang
2013-08-05 2:12 ` Chen Gang
2013-08-05 9:00 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375187380.2075.111.camel@joe-AO722 \
--to=joe@perches.com \
--cc=coda@cs.cmu.edu \
--cc=codalist@TELEMANN.coda.cs.cmu.edu \
--cc=gang.chen@asianux.com \
--cc=jaharkes@cs.cmu.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®