From: Alex Williamson <alex.williamson@redhat.com>
To: Takao Indoh <indou.takao@jp.fujitsu.com>
Cc: bhelgaas@google.com, rjw@sisk.pl, vgoyal@redhat.com,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
iommu@lists.linux-foundation.org, kexec@lists.infradead.org,
ishii.hironobu@jp.fujitsu.com, ddutile@redhat.com,
bill.sumner@hp.com, hbabu@us.ibm.com, linux-acpi@vger.kernel.org
Subject: Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA
Date: Thu, 01 Aug 2013 06:42:14 -0600 [thread overview]
Message-ID: <1375360934.31262.156.camel@ul30vt.home> (raw)
In-Reply-To: <51FA015E.10901@jp.fujitsu.com>
On Thu, 2013-08-01 at 15:34 +0900, Takao Indoh wrote:
> (2013/08/01 6:23), Rafael J. Wysocki wrote:
> > On Wednesday, July 31, 2013 03:08:03 PM Bjorn Helgaas wrote:
> >> [+cc Rafael, linux-acpi]
> >>
> >> On Tue, Jul 30, 2013 at 6:35 PM, Takao Indoh <indou.takao@jp.fujitsu.com> wrote:
> >>
> >>> On x86, currently IOMMU initialization run *after* PCI enumeration, but
> >>> what you are talking about is that it should be changed so that x86
> >>> IOMMU initialization is done *before* PCI enumeration like sparc, right?
> >>
> >> Yes. I don't know whether or when that initialization order will ever
> >> be changed, but I do think we should avoid building more
> >> infrastructure that depends on the current order.
> >>
> >> Changing the order is a pretty big deal because it's a lot more than
> >> just the IOMMU. Basically I think we should be enumerating ACPI
> >> devices, including the IOMMU, before PCI devices, but there's a lot of
> >> legacy involved in that area. Added Rafael in case he has any
> >> thoughts.
> >
> > Well, actually, I'm not really familiar with IOMMUs, sorry.
> >
> > I do think that initializing IOMMU before PCI enumeration would be better,
> > however. At least if the ordering should be the same on all architectures,
> > which I suppose is the case, that's the one I'd choose.
>
> Ok guys. If x86 IOMMU maintainer also thinks changing order is
> necessary, maybe I need to give up device reset in kdump kernel and
> consider doing it in panic kernel.
>
> Either way, I need bus reset interface to reset devices. Bjorn, could
> you review the bus reset patches Alex posted yesterday?
I'll post a non-RFC version today, I've made a couple cleanups, tuned
the delays and rolled in the AER version of secondary bus reset.
Thanks,
Alex
next prev parent reply other threads:[~2013-08-01 12:42 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-14 5:29 Takao Indoh
2013-05-14 22:04 ` Eric W. Biederman
2013-05-21 23:46 ` Takao Indoh
2013-06-06 7:25 ` Takao Indoh
2013-06-07 4:14 ` Bjorn Helgaas
2013-06-07 8:46 ` Takao Indoh
2013-06-11 2:20 ` Bjorn Helgaas
2013-06-11 6:08 ` Takao Indoh
2013-06-11 23:19 ` Sumner, William
2013-06-12 0:53 ` Bjorn Helgaas
2013-06-12 13:19 ` Don Dutile
2013-06-13 3:25 ` Takao Indoh
2013-06-12 4:45 ` Bjorn Helgaas
2013-06-13 2:44 ` Takao Indoh
2013-06-13 3:41 ` Bjorn Helgaas
2013-06-14 2:11 ` Takao Indoh
2013-07-24 6:29 ` Takao Indoh
2013-07-25 14:24 ` Vivek Goyal
2013-07-29 0:20 ` Takao Indoh
2013-07-25 17:00 ` Bjorn Helgaas
2013-07-29 0:37 ` Takao Indoh
2013-07-29 14:17 ` Bjorn Helgaas
2013-07-30 6:09 ` Takao Indoh
2013-07-30 15:59 ` Bjorn Helgaas
2013-07-31 0:35 ` Takao Indoh
2013-07-31 3:11 ` Alex Williamson
2013-07-31 5:50 ` Takao Indoh
2013-07-31 21:08 ` Bjorn Helgaas
2013-07-31 21:23 ` Rafael J. Wysocki
2013-08-01 6:34 ` Takao Indoh
2013-08-01 12:42 ` Alex Williamson [this message]
2013-08-01 13:20 ` Vivek Goyal
2013-07-31 19:56 ` Vivek Goyal
2013-07-31 16:09 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375360934.31262.156.camel@ul30vt.home \
--to=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=bill.sumner@hp.com \
--cc=ddutile@redhat.com \
--cc=hbabu@us.ibm.com \
--cc=indou.takao@jp.fujitsu.com \
--cc=iommu@lists.linux-foundation.org \
--cc=ishii.hironobu@jp.fujitsu.com \
--cc=kexec@lists.infradead.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®