From: Rupesh Gujare <rupesh.gujare@atmel.com>
To: <devel@linuxdriverproject.org>
Cc: <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<gregkh@linuxfoundation.org>
Subject: [PATCH 3/6] staging: ozwpan: Use kernel strncmp function.
Date: Thu, 1 Aug 2013 18:40:02 +0100 [thread overview]
Message-ID: <1375378806-17948-4-git-send-email-rupesh.gujare@atmel.com> (raw)
In-Reply-To: <1375378806-17948-1-git-send-email-rupesh.gujare@atmel.com>
Use kernel's strncmp() function instead of defining same within driver.
Signed-off-by: Rupesh Gujare <rupesh.gujare@atmel.com>
---
drivers/staging/ozwpan/ozproto.c | 17 +----------------
1 file changed, 1 insertion(+), 16 deletions(-)
diff --git a/drivers/staging/ozwpan/ozproto.c b/drivers/staging/ozwpan/ozproto.c
index 2dbaba6..ec60286 100644
--- a/drivers/staging/ozwpan/ozproto.c
+++ b/drivers/staging/ozwpan/ozproto.c
@@ -669,21 +669,6 @@ void oz_binding_add(const char *net_dev)
/*------------------------------------------------------------------------------
* Context: process
*/
-static int compare_binding_name(const char *s1, const char *s2)
-{
- int i;
- for (i = 0; i < OZ_MAX_BINDING_LEN; i++) {
- if (*s1 != *s2)
- return 0;
- if (!*s1++)
- return 1;
- s2++;
- }
- return 1;
-}
-/*------------------------------------------------------------------------------
- * Context: process
- */
static void pd_stop_all_for_device(struct net_device *net_dev)
{
struct list_head h;
@@ -715,7 +700,7 @@ void oz_binding_remove(const char *net_dev)
oz_dbg(ON, "Removing binding: %s\n", net_dev);
spin_lock_bh(&g_binding_lock);
list_for_each_entry(binding, &g_binding, link) {
- if (compare_binding_name(binding->name, net_dev)) {
+ if (strncmp(binding->name, net_dev, OZ_MAX_BINDING_LEN) == 0) {
oz_dbg(ON, "Binding '%s' found\n", net_dev);
found = 1;
break;
--
1.7.9.5
next prev parent reply other threads:[~2013-08-01 17:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 17:39 [PATCH 0/6] staging: ozwpan: Use Kernel API & Bug fixes Rupesh Gujare
2013-08-01 17:40 ` [PATCH 1/6] staging: ozwpan: Use kernel list function for managing interface list Rupesh Gujare
2013-08-01 17:40 ` [PATCH 2/6] staging: ozwpan: Mark string as const Rupesh Gujare
2013-08-01 18:17 ` Joe Perches
2013-08-01 17:40 ` Rupesh Gujare [this message]
2013-08-01 17:40 ` [PATCH 4/6] staging: ozwpan: Drop oldest ISOC frame instead of dropping latest Rupesh Gujare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375378806-17948-4-git-send-email-rupesh.gujare@atmel.com \
--to=rupesh.gujare@atmel.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®