From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: <linux-serial@vger.kernel.org>
Cc: Mischa Jonker <Mischa.Jonker@synopsys.com>,
Vineet Gupta <Vineet.Gupta1@synopsys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.cz>, <linux-kernel@vger.kernel.org>
Subject: [PATCH 2/2] serial/arc-uart: Remove the goto/label
Date: Thu, 1 Aug 2013 21:49:20 -0700 [thread overview]
Message-ID: <1375418960-21491-2-git-send-email-vgupta@synopsys.com> (raw)
In-Reply-To: <1375418960-21491-1-git-send-email-vgupta@synopsys.com>
Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
Cc: Mischa Jonker <mjonker@synopsys.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.cz>
Cc: linux-serial@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
drivers/tty/serial/arc_uart.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/tty/serial/arc_uart.c b/drivers/tty/serial/arc_uart.c
index 10f981b..c7aa313a 100644
--- a/drivers/tty/serial/arc_uart.c
+++ b/drivers/tty/serial/arc_uart.c
@@ -248,12 +248,9 @@ static void arc_serial_rx_chars(struct arc_uart_port *uart, unsigned int status)
ch = UART_GET_DATA(uart);
uart->port.icount.rx++;
- if (unlikely(uart_handle_sysrq_char(&uart->port, ch)))
- goto done;
+ if (!(uart_handle_sysrq_char(&uart->port, ch)))
+ uart_insert_char(&uart->port, status, RXOERR, ch, flg);
- uart_insert_char(&uart->port, status, RXOERR, ch, flg);
-
-done:
tty_flip_buffer_push(&uart->port.state->port);
} while (!((status = UART_GET_STATUS(uart)) & RXEMPTY));
}
--
1.8.1.2
prev parent reply other threads:[~2013-08-01 16:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-02 4:49 [PATCH 1/2] serial/arc-uart: Handle Rx Error Interrupts w/o any data Vineet Gupta
2013-08-02 4:49 ` Vineet Gupta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375418960-21491-2-git-send-email-vgupta@synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=Mischa.Jonker@synopsys.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®