mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hanna Linder <hannal@us.ibm.com>
To: sfeldma@pobox.com
Cc: Hanna Linder <hannal@us.ibm.com>,
	lkml <linux-kernel@vger.kernel.org>,
	kernel-janitors <kernel-janitors@lists.osdl.org>,
	greg@kroah.com, davem@davemloft.net, ecd@skynet.be,
	jj@sunsite.ms.mff.cuni.cz, anton@samba.org
Subject: Re: [RFT 2.6] ebus.c replace pci_find_device with pci_get_device
Date: Tue, 12 Oct 2004 09:43:13 -0700	[thread overview]
Message-ID: <137550000.1097599393@w-hlinder.beaverton.ibm.com> (raw)
In-Reply-To: <1097342474.3903.19.camel@sfeldma-mobl2.dsl-verizon.net>

--On Saturday, October 09, 2004 10:21:15 AM -0700 Scott Feldman <sfeldma@pobox.com> wrote:

> On Fri, 2004-10-08 at 15:53, Hanna Linder wrote:
>> @@ -528,7 +528,7 @@ static struct pci_dev *find_next_ebus(st
>>  	struct pci_dev *pdev = start;
>>  
>>  	do {
>> -		pdev = pci_find_device(PCI_VENDOR_ID_SUN, PCI_ANY_ID, pdev);
>> +		pdev = pci_get_device(PCI_VENDOR_ID_SUN, PCI_ANY_ID, pdev);
>>  		if (pdev &&
>>  		    (pdev->device == PCI_DEVICE_ID_SUN_EBUS ||
>>  		     pdev->device == PCI_DEVICE_ID_SUN_RIO_EBUS))
> 
> ebus_init() needs pci_put_dev(pdev) cleanup.
> 
> -scott
> 
> 

This is in a while loop with the pdev in the from* position. The dereference is
done automattically.

Thanks.

Hanna


  reply	other threads:[~2004-10-12 16:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-08 22:53 Hanna Linder
2004-10-09 17:21 ` Scott Feldman
2004-10-12 16:43   ` Hanna Linder [this message]
  -- strict thread matches above, loose matches on Subject: below --
2004-10-08 22:26 Hanna Linder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=137550000.1097599393@w-hlinder.beaverton.ibm.com \
    --to=hannal@us.ibm.com \
    --cc=anton@samba.org \
    --cc=davem@davemloft.net \
    --cc=ecd@skynet.be \
    --cc=greg@kroah.com \
    --cc=jj@sunsite.ms.mff.cuni.cz \
    --cc=kernel-janitors@lists.osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sfeldma@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®