Re: Linux 3.2.50

[Ben Hutchings <ben@decadent.org.uk>]

[-- Attachment #1: Type: text/plain, Size: 1091 bytes --]

On Sat, 2013-08-03 at 09:09 +0800, Teck Choon Giam wrote:
[...]
> I am getting the following error while trying to compile for 32bit in
> Scientific Linux 6.4:
> 
> drivers/net/ifb.c: In function 'ifb_init_module':
> drivers/net/ifb.c:298: error: implicit declaration of function 'cond_resched'
> make[2]: *** [drivers/net/ifb.o] Error 1
> 
> Missing include of linux/sched.h in drivers/net/ifb.c file?
> 
> I tried the following patch and it does compile successfully:
> 
> --- a/drivers/net/ifb.c    2013-08-03 04:15:12.000000000 +0800
> +++ b/drivers/net/ifb.c 2013-08-03 08:43:29.040492584 +0800
> @@ -34,6 +34,7 @@
>  #include <linux/init.h>
>  #include <linux/interrupt.h>
>  #include <linux/moduleparam.h>
> +#include <linux/sched.h>
>  #include <net/pkt_sched.h>
>  #include <net/net_namespace.h>
> 
> 
> FYI and comment please.

Yes I think that's the right change.  Linux 3.0.88-rc1 had the same
problem and I should have remembered this was needed.

Ben.

-- 
Ben Hutchings
Quantity is no substitute for quality, but it's the only one we've got.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]