mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Myklebust, Trond" <Trond.Myklebust@netapp.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>,
	Steve Dickson <steved@redhat.com>,
	David Quigley <dpquigl@davequigley.com>
Cc: "kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>,
	"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fs/nfs/inode.c: adjust code alignment
Date: Mon, 5 Aug 2013 14:59:55 +0000	[thread overview]
Message-ID: <1375714793.7337.12.camel@leira.trondhjem.org> (raw)
In-Reply-To: <1375714059-29567-2-git-send-email-Julia.Lawall@lip6.fr>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1742 bytes --]

On Mon, 2013-08-05 at 16:47 +0200, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> ---
> 
> This patch adjusts the code so that the alignment matches the current
> semantics.  I have no idea if it is the intended semantics, though.  Should
> the call to nfs_setsecurity also be under the else?
> 

>  fs/nfs/inode.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c
> index af6e806..d8ad685 100644
> --- a/fs/nfs/inode.c
> +++ b/fs/nfs/inode.c
> @@ -463,7 +463,7 @@ nfs_fhget(struct super_block *sb, struct nfs_fh
> *fh, struct nfs_fattr *fattr, st
>                 unlock_new_inode(inode);
>         } else
>                 nfs_refresh_inode(inode, fattr);
> -               nfs_setsecurity(inode, fattr, label);
> +       nfs_setsecurity(inode, fattr, label);
>         dprintk("NFS: nfs_fhget(%s/%Ld fh_crc=0x%08x ct=%d)\n",
>                 inode->i_sb->s_id,
>                 (long long)NFS_FILEID(inode),

Hi Julia,

Thanks for pointing this out! Given that the 'then' clause of the if
statement already calls nfs_setsecurity before unlocking the inode, I
suspect that the above _should_ really be part of the 'else' clause. 

That said, I can't see that calling nfs_setsecurity twice on the inode
can cause any unintended side-effects, so I suggest that we rather queue
the patch up for inclusion in 3.12.
Steve and Dave, any comments?

-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@netapp.com
www.netapp.com
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

  reply	other threads:[~2013-08-05 14:59 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-05 14:47 [PATCH] " Julia Lawall
2013-08-05 14:47 ` [PATCH] fs/nfs/inode.c: " Julia Lawall
2013-08-05 14:59   ` Myklebust, Trond [this message]
2013-08-06 18:04     ` Steve Dickson
2013-08-07  1:58       ` Dave Quigley
2013-08-05 14:47 ` [PATCH] drivers/scsi/lpfc/lpfc_init.c: " Julia Lawall
2013-08-05 14:47 ` [PATCH] net/vmw_vsock/af_vsock.c: drop unneeded semicolon Julia Lawall
2013-08-05 18:08   ` David Miller
2013-08-05 14:47 ` [PATCH] trivial: adjust code alignment Julia Lawall
2013-08-05 16:06   ` Dan Carpenter
2013-08-05 16:17     ` Joe Perches
2013-08-05 16:30       ` Dan Carpenter
2013-08-06  0:51         ` Joe Perches
2013-08-05 16:19     ` Julia Lawall
2013-08-05 16:24       ` walter harms
2013-08-05 16:28         ` Julia Lawall
2013-08-05 17:05         ` Dan Carpenter
2013-08-05 16:52       ` Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1375714793.7337.12.camel@leira.trondhjem.org \
    --to=trond.myklebust@netapp.com \
    --cc=Julia.Lawall@lip6.fr \
    --cc=dpquigl@davequigley.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=steved@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®