From: Joe Perches <joe@perches.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Phil Carmody <phil.carmody@partner.samsung.com>,
Andy Whitcroft <apw@canonical.com>,
linux-kernel@vger.kernel.org,
devel <devel@linuxdriverproject.org>,
kernel-janitors <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] checkpatch: Better --fix of SPACING errors.
Date: Tue, 06 Aug 2013 21:00:13 -0700 [thread overview]
Message-ID: <1375848013.2424.71.camel@joe-AO722> (raw)
In-Reply-To: <55837ac7d8f48eb8dc9060f1b705c9c8b01bea59.1375843905.git.joe@perches.com>
On Tue, 2013-08-06 at 19:55 -0700, Joe Perches wrote:
> Previous attempt at fixing SPACING errors could
> make a hash of several defects.
I have run this against drivers/staging/...
It works rather better than the older version.
It does have an issue with c99 style comments
when it needs to rewrite spacing as well.
If you use this with -f, please convert the
c99 // comments to /* ... */ first using the
--types c99_comments option,
Maybe use:
$ ./scripts/checkpatch.pl -f --fix --types=c99_comments <file>
$ mv <file>.EXPERIMENTAL-checkpatch-fixes <file>
$ ./scripts/checkpatch.pl -f --fix --types=spacing <file>
$ mv <file>.EXPERIMENTAL-checkpatch-fixes <file>
$ git diff <file>
prev parent reply other threads:[~2013-08-07 4:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-07 2:55 Joe Perches
2013-08-07 4:00 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375848013.2424.71.camel@joe-AO722 \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phil.carmody@partner.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®