From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757267Ab3HGIpu (ORCPT ); Wed, 7 Aug 2013 04:45:50 -0400 Received: from kirsty.vergenet.net ([202.4.237.240]:55788 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756301Ab3HGIpp (ORCPT ); Wed, 7 Aug 2013 04:45:45 -0400 From: Simon Horman To: Andrew Morton , "Eric W. Biederman" Cc: kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Zhang Yanfei , Xishi Qiu , Simon Horman Subject: [PATCH] kexec: remove unnecessary return Date: Wed, 7 Aug 2013 17:45:36 +0900 Message-Id: <1375865136-21006-1-git-send-email-horms@verge.net.au> X-Mailer: git-send-email 1.8.3.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xishi Qiu Code can not run here forever, so remove the unnecessary return. Signed-off-by: Xishi Qiu Suggested-by: Zhang Yanfei Reviewed-by: Zhang Yanfei Signed-off-by: Simon Horman --- kernel/kexec.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) Andrew, could you consider picking up this patch? diff --git a/kernel/kexec.c b/kernel/kexec.c index 59f7b55..2a74f30 100644 --- a/kernel/kexec.c +++ b/kernel/kexec.c @@ -1474,11 +1474,8 @@ static int __init __parse_crashkernel(char *cmdline, if (first_colon && (!first_space || first_colon < first_space)) return parse_crashkernel_mem(ck_cmdline, system_ram, crash_size, crash_base); - else - return parse_crashkernel_simple(ck_cmdline, crash_size, - crash_base); - return 0; + return parse_crashkernel_simple(ck_cmdline, crash_size, crash_base); } /* -- 1.8.3.2