From: Mark Langsdorf <mark.langsdorf@calxeda.com>
To: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
tj@kernel.org, devicetree@vger.kernel.org, pawel.moll@arm.com,
mark.rutland@arm.com, swarren@wwwdotorg.org,
ian.campbell@citrix.com, rob.herring@calxeda.com,
sergei.shtylyov@cogentembedded.com
Cc: Mark Langsdorf <mark.langsdorf@calxeda.com>
Subject: [PATCH v3 1/5] sata, highbank: fix ordering of SGPIO signals
Date: Wed, 7 Aug 2013 10:52:34 -0500 [thread overview]
Message-ID: <1375890758-30265-1-git-send-email-mark.langsdorf@calxeda.com> (raw)
The ACTIVITY and ERROR signals were reversed in the original commit.
Fix that so that hard drive activity does not show up on the error
light, and attempts to indicate that the hard drive is failing do
not show up as hard drive activity. This fixes a fairly serious
functional bug in the driver, but failing to apply this patch will
not cause any stability issues on the system.
Signed-off-by: Mark Langsdorf <mark.langsdorf@calxeda.com>
---
Changes from v2
Further rewords of the commit message.
Changes from v1
Expanded commit message explaining the problems with the
unpatched code.
drivers/ata/sata_highbank.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/sata_highbank.c b/drivers/ata/sata_highbank.c
index d047d92..e9a4f46 100644
--- a/drivers/ata/sata_highbank.c
+++ b/drivers/ata/sata_highbank.c
@@ -86,11 +86,11 @@ struct ecx_plat_data {
#define SGPIO_SIGNALS 3
#define ECX_ACTIVITY_BITS 0x300000
-#define ECX_ACTIVITY_SHIFT 2
+#define ECX_ACTIVITY_SHIFT 0
#define ECX_LOCATE_BITS 0x80000
#define ECX_LOCATE_SHIFT 1
#define ECX_FAULT_BITS 0x400000
-#define ECX_FAULT_SHIFT 0
+#define ECX_FAULT_SHIFT 2
static inline int sgpio_bit_shift(struct ecx_plat_data *pdata, u32 port,
u32 shift)
{
--
1.8.1.2
next reply other threads:[~2013-08-07 15:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-07 15:52 Mark Langsdorf [this message]
2013-08-07 15:52 ` [PATCH v3 2/5] sata highbank: enable 64-bit DMA mask when using LPAE Mark Langsdorf
2013-08-09 16:08 ` Tejun Heo
2013-08-07 15:52 ` [PATCH v3 3/5] devicetree: create a separate binding description for sata_highbank Mark Langsdorf
2013-08-07 16:13 ` Kumar Gala
2013-08-08 9:46 ` Mark Rutland
2013-08-09 16:10 ` Tejun Heo
2013-08-09 16:10 ` Tejun Heo
2013-08-09 16:12 ` Mark Langsdorf
2013-08-09 16:15 ` Tejun Heo
2013-08-07 15:52 ` [PATCH v3 4/5] sata, highbank: set tx_atten override bits Mark Langsdorf
2013-08-07 15:52 ` [PATCH v3 5/5] sata, highbank: send extra clock cycles in SGPIO patterns Mark Langsdorf
2013-08-09 16:07 ` [PATCH v3 1/5] sata, highbank: fix ordering of SGPIO signals Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375890758-30265-1-git-send-email-mark.langsdorf@calxeda.com \
--to=mark.langsdorf@calxeda.com \
--cc=devicetree@vger.kernel.org \
--cc=ian.campbell@citrix.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=swarren@wwwdotorg.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®