From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Paul McQuade <paulmcquad@gmail.com>,
gregkh@linuxfoundation.org,
Linux-Devel <devel@driverdev.osuosl.org>,
Linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] Staging: BCM: Removed more whitespace/Errors
Date: Thu, 08 Aug 2013 14:03:08 -0700 [thread overview]
Message-ID: <1375995788.2087.8.camel@joe-AO722> (raw)
In-Reply-To: <20130808204455.GC5502@mwanda>
On Thu, 2013-08-08 at 23:44 +0300, Dan Carpenter wrote:
> On Thu, Aug 08, 2013 at 06:03:49PM +0100, Paul McQuade wrote:
> > -int InterfaceFileDownload( PVOID psIntfAdapter,
> > - struct file *flp,
> > - unsigned int on_chip_loc);
> > +int InterfaceFileDownload(PVOID psIntfAdapter,
> > + struct file *flp,
> > + unsigned int on_chip_loc);
>
>
> The very first line in this patch is totally wrong... :(
>
> This is an automated patch.
It is?
It doesn't look like an automated patch to me.
It looks like there are too many different style
choices for it to have been done by a machine.
Why do you think that?
Paul, how did you create this patch?
Dan, if you get a chance, could you try to use
checkpatch with the --fix option with specific
--types like SPACING and PARENTHESIS_ALIGNMENT
and tell me if you think it's OK?
prev parent reply other threads:[~2013-08-08 21:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-08 17:03 Paul McQuade
2013-08-08 17:23 ` Joe Perches
2013-08-08 20:44 ` Dan Carpenter
2013-08-08 21:03 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375995788.2087.8.camel@joe-AO722 \
--to=joe@perches.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmcquad@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®