From: Joe Perches <joe@perches.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Julia Lawall <julia.lawall@lip6.fr>, LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH next] checkpatch: Fix perl version 5.12 and earlier incompatibility
Date: Sat, 10 Aug 2013 07:40:07 -0700 [thread overview]
Message-ID: <1376145607.2083.15.camel@joe-AO722> (raw)
commit 203489a33 ("checkpatch: add --types option
to report only specific message types") uses a
perl syntax introduced in perl version 5.14.
Use the backward compatible perl syntax instead.
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Joe Perches <joe@perches.com>
---
scripts/checkpatch.pl | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 3ba2db6..51ee331 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -174,9 +174,9 @@ sub hash_save_array_words {
sub hash_show_words {
my ($hashRef, $prefix) = @_;
- if ($quiet == 0 && keys $hashRef) {
+ if ($quiet == 0 && keys %{$hashRef}) {
print "NOTE: $prefix message types:";
- foreach my $word (sort keys $hashRef) {
+ foreach my $word (sort keys %{$hashRef}) {
print " $word";
}
print "\n\n";
reply other threads:[~2013-08-10 14:40 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1376145607.2083.15.camel@joe-AO722 \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®