mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Fred Chen <fchen@linux.vnet.ibm.com>
Cc: x86@kernel.org, hpa@zytor.com, tglx@linutronix.de,
	mingo@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] strlen patch
Date: Tue, 13 Aug 2013 11:18:12 -0700	[thread overview]
Message-ID: <1376417892.1949.41.camel@joe-AO722> (raw)
In-Reply-To: <1376417580-11554-1-git-send-email-fchen@linux.vnet.ibm.com>

On Tue, 2013-08-13 at 11:13 -0700, Fred Chen wrote:
> fixes sparse error "arch/x86/boot/string.c:119:8: warning: symbol 'strlen' was not declared." by declaring it in arch/x86/boot/boot.h.
[]
> diff --git a/arch/x86/boot/boot.h b/arch/x86/boot/boot.h
[]
> @@ -355,6 +355,7 @@ int strncmp(const char *cs, const char *ct, size_t count);
>  size_t strnlen(const char *s, size_t maxlen);
>  unsigned int atou(const char *s);
>  unsigned long long simple_strtoull(const char *cp, char **endp, unsigned int base);
> +size_t strlen(const char *s);

better placed before strnlen no?
 


  reply	other threads:[~2013-08-13 18:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-13 18:13 Fred Chen
2013-08-13 18:18 ` Joe Perches [this message]
2013-08-13 18:30 ` [tip:x86/cleanups] x86, boot: Fix warning due to undeclared strlen() tip-bot for Fred Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1376417892.1949.41.camel@joe-AO722 \
    --to=joe@perches.com \
    --cc=fchen@linux.vnet.ibm.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®