From: Hayes Wang <hayeswang@realtek.com>
To: <romieu@fr.zoreil.com>, <netdev@vger.kernel.org>
Cc: <nic_swsd@realtek.com>, <linux-kernel@vger.kernel.org>,
<linux-usb@vger.kernel.org>, Hayes Wang <hayeswang@realtek.com>
Subject: [PATCH net-next 7/7] r8152: add comments
Date: Fri, 16 Aug 2013 16:09:38 +0800 [thread overview]
Message-ID: <1376640578-4258-7-git-send-email-hayeswang@realtek.com> (raw)
In-Reply-To: <1376640578-4258-1-git-send-email-hayeswang@realtek.com>
Add comments.
Signed-off-by: Hayes Wang <hayeswang@realtek.com>
---
drivers/net/usb/r8152.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index 825edfe..f3fce41 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -790,6 +790,9 @@ static void read_bulk_callback(struct urb *urb)
return;
netdev = tp->netdev;
+
+ /* When link down, the driver would cancel all bulks. */
+ /* This avoid the re-submitting bulk */
if (!netif_carrier_ok(netdev))
return;
@@ -1296,6 +1299,8 @@ static void bottom_half(unsigned long data)
if (!test_bit(WORK_ENABLE, &tp->flags))
return;
+ /* When link down, the driver would cancel all bulks. */
+ /* This avoid the re-submitting bulk */
if (!netif_carrier_ok(tp->netdev))
return;
--
1.8.3.1
next prev parent reply other threads:[~2013-08-16 8:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-16 8:09 [PATCH net-next 1/7] r8152: remove clearing the memory to zero for netdev priv Hayes Wang
2013-08-16 8:09 ` [PATCH net-next 2/7] r8152: replace void * with struct r8152 * Hayes Wang
2013-08-16 8:09 ` [PATCH net-next 3/7] r8152: replace lockflags with flags Hayes Wang
2013-08-16 8:09 ` [PATCH net-next 4/7] r8152: adjust some duplicated code Hayes Wang
2013-08-16 8:09 ` [PATCH net-next 5/7] r8152: move some declearation of variables Hayes Wang
2013-08-16 8:09 ` [PATCH net-next 6/7] r8152: adjust tx_bottom function Hayes Wang
2013-08-16 8:09 ` Hayes Wang [this message]
2013-08-20 7:09 ` [PATCH net-next 1/7] r8152: remove clearing the memory to zero for netdev priv David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1376640578-4258-7-git-send-email-hayeswang@realtek.com \
--to=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®