mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jerry Snitselaar <jerry.snitselaar@oracle.com>
To: linux-kernel@vger.kernel.org
Cc: linux-acpi@vger.kernel.org, mika.westerberg@linux.intel.com, rjw@sisk.pl
Subject: [PATCH] acpi_i2c: set MODULE_LICENSE, MODULE_AUTHOR, and  MODULE_DESCRIPTION
Date: Fri, 16 Aug 2013 18:26:35 -0700	[thread overview]
Message-ID: <1376702795-25912-1-git-send-email-jerry.snitselaar@oracle.com> (raw)

Without MODULE_LICENSE set, I get the following with modprobe:

acpi_i2c: module license 'unspecified' taints kernel.
acpi_i2c: Unknown symbol i2c_new_device (err 0)
acpi_i2c: Unknown symbol acpi_dev_get_resources (err 0)
acpi_i2c: Unknown symbol acpi_dev_resource_interrupt (err 0)
acpi_i2c: Unknown symbol acpi_dev_free_resource_list (err 0)

Signed-off-by: Jerry Snitselaar <jerry.snitselaar@oracle.com>
---
 drivers/acpi/acpi_i2c.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/acpi/acpi_i2c.c b/drivers/acpi/acpi_i2c.c
index 82045e3..2c5c65d 100644
--- a/drivers/acpi/acpi_i2c.c
+++ b/drivers/acpi/acpi_i2c.c
@@ -14,9 +14,14 @@
 #include <linux/export.h>
 #include <linux/i2c.h>
 #include <linux/ioport.h>
+#include <linux/module.h>
 
 ACPI_MODULE_NAME("i2c");
 
+MODULE_DESCRIPTION("ACPI I2C enumeration support");
+MODULE_AUTHOR("Mika Westerberg");
+MODULE_LICENSE("GPL");
+
 static int acpi_i2c_add_resource(struct acpi_resource *ares, void *data)
 {
 	struct i2c_board_info *info = data;
-- 
1.8.4.rc3.2.g2c2b664


             reply	other threads:[~2013-08-17  1:27 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-17  1:26 Jerry Snitselaar [this message]
2013-08-19  6:16 ` Mika Westerberg
2013-08-19 23:30   ` Rafael J. Wysocki
2013-08-19 23:35     ` Jerry Snitselaar
2013-08-19 23:48       ` Rafael J. Wysocki
2013-08-20  3:34         ` Jerry Snitselaar
2013-08-20  7:28           ` Mika Westerberg
2013-08-20  8:00             ` Jerry Snitselaar
2013-08-20  8:14               ` Mika Westerberg
2013-08-20  8:18                 ` Mika Westerberg
2013-08-20 12:38                   ` Rafael J. Wysocki
  -- strict thread matches above, loose matches on Subject: below --
2013-08-16 21:40 Jerry Snitselaar
2013-08-17  5:12 ` Jerry Snitselaar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1376702795-25912-1-git-send-email-jerry.snitselaar@oracle.com \
    --to=jerry.snitselaar@oracle.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®