From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752406Ab3HQGow (ORCPT ); Sat, 17 Aug 2013 02:44:52 -0400 Received: from fallback7.mail.ru ([94.100.176.135]:53241 "EHLO fallback7.mail.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752012Ab3HQGoi (ORCPT ); Sat, 17 Aug 2013 02:44:38 -0400 From: Alexander Shiyan To: rtc-linux@googlegroups.com Cc: Alessandro Zummo , linux-kernel@vger.kernel.org, Alexander Shiyan Subject: [PATCH RESEND 3/3] rtc: ds1742: Report to RTC core if retrieved time is invalid Date: Sat, 17 Aug 2013 10:43:56 +0400 Message-Id: <1376721836-27153-3-git-send-email-shc_work@mail.ru> X-Mailer: git-send-email 1.8.1.5 In-Reply-To: <1376721836-27153-1-git-send-email-shc_work@mail.ru> References: <1376721836-27153-1-git-send-email-shc_work@mail.ru> X-Spam: Not detected X-Mras: Ok Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Let RTC core decides if the retrieved time is invalid, instead of processing errors in the driver. Signed-off-by: Alexander Shiyan --- drivers/rtc/rtc-ds1742.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/rtc/rtc-ds1742.c b/drivers/rtc/rtc-ds1742.c index 139934f..17b73fd 100644 --- a/drivers/rtc/rtc-ds1742.c +++ b/drivers/rtc/rtc-ds1742.c @@ -115,11 +115,7 @@ static int ds1742_rtc_read_time(struct device *dev, struct rtc_time *tm) /* year is 1900 + tm->tm_year */ tm->tm_year = bcd2bin(year) + bcd2bin(century) * 100 - 1900; - if (rtc_valid_tm(tm) < 0) { - dev_err(dev, "retrieved date/time is not valid.\n"); - rtc_time_to_tm(0, tm); - } - return 0; + return rtc_valid_tm(tm); } static const struct rtc_class_ops ds1742_rtc_ops = { -- 1.8.1.5