From: Andi Shyti <andi@etezian.org>
To: josh.h.morris@us.ibm.com, pjk1939@linux.vnet.ibm.com
Cc: linux-kernel@vger.kernel.org, andi@etezian.org
Subject: [PATCH] rsxx: core: fix memory leak
Date: Mon, 19 Aug 2013 12:20:31 +0200 [thread overview]
Message-ID: <1376907631-13725-1-git-send-email-andi@etezian.org> (raw)
if 'copy_from_user' fails, the 'rsxx_cram_write()' function
returns without freeing the allocated buffer 'buf'.
Free 'buf' before returning.
This issue has been reported by scan.coverity.com
Signed-off-by: Andi Shyti <andi@etezian.org>
---
drivers/block/rsxx/core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/block/rsxx/core.c b/drivers/block/rsxx/core.c
index 6e85e21..1ddb284 100644
--- a/drivers/block/rsxx/core.c
+++ b/drivers/block/rsxx/core.c
@@ -223,8 +223,10 @@ static ssize_t rsxx_cram_write(struct file *fp, const char __user *ubuf,
return -ENOMEM;
st = copy_from_user(buf, ubuf, cnt);
- if (st)
+ if (st) {
+ kfree(buf);
return st;
+ }
info->f_pos = (u32)*ppos + info->offset;
--
1.8.4.rc2
next reply other threads:[~2013-08-19 10:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-19 10:20 Andi Shyti [this message]
2013-08-19 16:36 ` [PATCH v2 0/1] fix meamleak on rsxx/core.c Andi Shyti
2013-08-19 16:36 ` [PATCH v2 1/1] rsxx: core: fix memory leak Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1376907631-13725-1-git-send-email-andi@etezian.org \
--to=andi@etezian.org \
--cc=josh.h.morris@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pjk1939@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®