From: Libin <huawei.libin@huawei.com>
To: <tj@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <wangyijing@huawei.com>,
<guohanjun@huawei.com>
Subject: [PATCH v2 2/3] workqueue: Fix manage_workers() RETURNS description
Date: Wed, 21 Aug 2013 08:50:40 +0800 [thread overview]
Message-ID: <1377046241-18516-3-git-send-email-huawei.libin@huawei.com> (raw)
In-Reply-To: <1377046241-18516-1-git-send-email-huawei.libin@huawei.com>
No functional change. The comment of function manage_workers()
RETURNS description is obvious wrong, same as the CONTEXT.
Fix it.
Signed-off-by: Libin <huawei.libin@huawei.com>
---
kernel/workqueue.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index 26644ce..46a0de0 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -2034,8 +2034,11 @@ static bool maybe_destroy_workers(struct worker_pool *pool)
* multiple times. Does GFP_KERNEL allocations.
*
* RETURNS:
- * spin_lock_irq(pool->lock) which may be released and regrabbed
- * multiple times. Does GFP_KERNEL allocations.
+ * %false if the pool don't need management and the caller can safely
+ * start processing works, %true indicates that the function released
+ * pool->lock and reacquired it to perform some management function
+ * and that the conditions that the caller verified while holding the
+ * lock before calling the function might no longer be true.
*/
static bool manage_workers(struct worker *worker)
{
--
1.8.2.1
next prev parent reply other threads:[~2013-08-21 0:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 0:50 [PATCH v2 0/3] workqueue: Comment/Doc correction with no functional change Libin
2013-08-21 0:50 ` [PATCH v2 1/3] workqueue: Comment correction in file header Libin
2013-08-21 0:50 ` Libin [this message]
2013-08-21 20:52 ` [PATCH v2 2/3] workqueue: Fix manage_workers() RETURNS description Randy Dunlap
2013-08-21 0:50 ` [PATCH v2 3/3] workqueue: Correct/Drop references to gcwq in Documentation Libin
2013-08-21 20:55 ` Randy Dunlap
2013-08-21 14:32 ` [PATCH v2 0/3] workqueue: Comment/Doc correction with no functional change Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377046241-18516-3-git-send-email-huawei.libin@huawei.com \
--to=huawei.libin@huawei.com \
--cc=guohanjun@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=wangyijing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®