From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752825Ab3HUUHp (ORCPT ); Wed, 21 Aug 2013 16:07:45 -0400 Received: from mga09.intel.com ([134.134.136.24]:13150 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752393Ab3HUUHn (ORCPT ); Wed, 21 Aug 2013 16:07:43 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.89,929,1367996400"; d="scan'208";a="366418183" From: Andi Kleen To: x86@kernel.org Cc: linux-kernel@vger.kernel.org, Andi Kleen Subject: [PATCH] x86, asmlinkage: Fix warning in xen asmlinkage change v2 Date: Wed, 21 Aug 2013 13:07:42 -0700 Message-Id: <1377115662-4865-1-git-send-email-andi@firstfloor.org> X-Mailer: git-send-email 1.8.3.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andi Kleen Current code uses asmlinkage for functions without arguments. This adds an implicit regparm(0) which creates a warning when assigning the function to pointers. Use __visible for the functions without arguments. This avoids having to add regparm(0) to function pointers. Since they have no arguments it does not make any difference. Signed-off-by: Andi Kleen --- arch/x86/xen/xen-ops.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/x86/xen/xen-ops.h b/arch/x86/xen/xen-ops.h index d380213..95f8c61 100644 --- a/arch/x86/xen/xen-ops.h +++ b/arch/x86/xen/xen-ops.h @@ -105,7 +105,7 @@ static inline void __init xen_init_apic(void) /* Declare an asm function, along with symbols needed to make it inlineable */ #define DECL_ASM(ret, name, ...) \ - asmlinkage ret name(__VA_ARGS__); \ + __visible ret name(__VA_ARGS__); \ extern char name##_end[] __visible; \ extern char name##_reloc[] __visible @@ -115,11 +115,11 @@ DECL_ASM(unsigned long, xen_save_fl_direct, void); DECL_ASM(void, xen_restore_fl_direct, unsigned long); /* These are not functions, and cannot be called normally */ -asmlinkage void xen_iret(void); -asmlinkage void xen_sysexit(void); -asmlinkage void xen_sysret32(void); -asmlinkage void xen_sysret64(void); -asmlinkage void xen_adjust_exception_frame(void); +__visible void xen_iret(void); +__visible void xen_sysexit(void); +__visible void xen_sysret32(void); +__visible void xen_sysret64(void); +__visible void xen_adjust_exception_frame(void); extern int xen_panic_handler_init(void); -- 1.8.3.1