From: James Bottomley <jbottomley@parallels.com>
To: Akinobu Mita <akinobu.mita@gmail.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Joe Perches <joe@perches.com>, Zhi Yong Wu <zwu.kernel@gmail.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
linux-kernel mlist <linux-kernel@vger.kernel.org>,
Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>,
"Paul Bolle" <pebolle@tiscali.nl>,
Douglas Gilbert <dgilbert@interlog.com>
Subject: Re: [PATCH] scsi: fix the build warning
Date: Thu, 22 Aug 2013 14:27:07 +0000 [thread overview]
Message-ID: <1377181627.2009.2.camel@dabdike.int.hansenpartnership.com> (raw)
In-Reply-To: <CAC5umyjHqqNnS_LAP_bfU0zs52JbuAYr9jLwDhgaQ7TmrACUHA@mail.gmail.com>
On Thu, 2013-08-22 at 21:42 +0900, Akinobu Mita wrote:
> 2013/8/22 Martin K. Petersen <martin.petersen@oracle.com>:
> >>>>>> "Joe" == Joe Perches <joe@perches.com> writes:
> >
> > Joe> I don't get this build warning in the first place and I think the
> > Joe> scsi_debug file is quite old and probably doesn't need to be
> > Joe> changed at all.
> >
> > guard isn't a boolean, it selects the checksum algorithm used.
> >
> > Also, I believe Akinobu's recent reorganization of this code in question
> > fixed the warning.
>
> Unfortunately, this warning isn't fixed in linux-next, either.
> Paul Bolle also sent a patch that fixes the same warning in a little
> bit different way.
Well, it is and it isn't. Whether you see the warning seems to depend
on how gcc was built. My take is that an impossible default case just
to keep some versions of gcc quiet is a bit pointless.
James
next prev parent reply other threads:[~2013-08-22 14:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 0:44 zwu.kernel
2013-08-22 1:02 ` Joe Perches
2013-08-22 1:05 ` Zhi Yong Wu
2013-08-22 1:17 ` Joe Perches
2013-08-22 1:25 ` Martin K. Petersen
2013-08-22 1:55 ` Joe Perches
2013-08-22 1:59 ` Zhi Yong Wu
2013-08-22 2:25 ` Joe Perches
2013-08-22 12:42 ` Akinobu Mita
2013-08-22 14:27 ` James Bottomley [this message]
2013-08-22 14:49 ` Akinobu Mita
2013-09-20 9:53 ` Paul Bolle
2013-09-20 14:32 ` Akinobu Mita
2013-09-20 16:14 ` Paul Bolle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377181627.2009.2.camel@dabdike.int.hansenpartnership.com \
--to=jbottomley@parallels.com \
--cc=akinobu.mita@gmail.com \
--cc=dgilbert@interlog.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=pebolle@tiscali.nl \
--cc=wuzhy@linux.vnet.ibm.com \
--cc=zwu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®