From: Joe Perches <joe@perches.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: Andy Whitcroft <apw@canonical.com>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: checkpatch.pl: false warning about "-p0 patch"
Date: Thu, 22 Aug 2013 15:30:38 -0700 [thread overview]
Message-ID: <1377210638.12003.52.camel@joe-AO722> (raw)
In-Reply-To: <CAN8TOE9AFSVOhP1fazHK_VWZjDtqtd-Co47pGGFVvuS99qNy4A@mail.gmail.com>
On Thu, 2013-08-22 at 15:14 -0700, Brian Norris wrote:
> I realized the problem is simply with the existence of a file
> named 'b'. That is, checkpatch will give a warning for this:
> touch b
> git format-patch -1 --stdout | scripts/checkpatch.pl -
> WARNING: patch prefix 'b' exists, appears to be a -p0 patch
> Is that expected?
Yes. Basically, don't have a file (or a directory)
named a or b in the kernel root directory.
if (!$file && $tree && $p1_prefix ne '' &&
-e "$root/$p1_prefix") {
WARN("PATCH_PREFIX",
"patch prefix '$p1_prefix' exists, appears to be a -p0 patch\n");
}
prev parent reply other threads:[~2013-08-22 22:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 21:45 Brian Norris
2013-08-22 21:57 ` Joe Perches
2013-08-22 22:14 ` Brian Norris
2013-08-22 22:30 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377210638.12003.52.camel@joe-AO722 \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=computersforpeace@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®