mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Adrian Hunter <adrian.hunter@intel.com>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: linux-kernel@vger.kernel.org, David Ahern <dsahern@gmail.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Jiri Olsa <jolsa@redhat.com>, Mike Galbraith <efault@gmx.de>,
	Namhyung Kim <namhyung@gmail.com>,
	Paul Mackerras <paulus@samba.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Stephane Eranian <eranian@google.com>,
	Ingo Molnar <mingo@kernel.org>
Subject: [PATCH V12 10/13] perf tools: add missing 'abi' member to 'struct regs_dump'
Date: Mon, 26 Aug 2013 16:00:27 +0300	[thread overview]
Message-ID: <1377522030-27870-11-git-send-email-adrian.hunter@intel.com> (raw)
In-Reply-To: <1377522030-27870-1-git-send-email-adrian.hunter@intel.com>

And store the parsed value there.  Note that the 'abi' is
0 (no registers), 1 (32-bit registers) or 2 (64-bit registers),
but the registers are anyway copied one-by-one as 64-bit
values onto the event i.e. see 'perf_output_sample_regs()'

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Acked-by: Jiri Olsa <jolsa@redhat.com>
---
 tools/perf/util/event.h | 1 +
 tools/perf/util/evsel.c | 7 +++----
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/tools/perf/util/event.h b/tools/perf/util/event.h
index b0921fe..6bb5d7c 100644
--- a/tools/perf/util/event.h
+++ b/tools/perf/util/event.h
@@ -78,6 +78,7 @@ struct sample_event {
 };
 
 struct regs_dump {
+	u64 abi;
 	u64 *regs;
 };
 
diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
index db4e431..1184188 100644
--- a/tools/perf/util/evsel.c
+++ b/tools/perf/util/evsel.c
@@ -1416,13 +1416,12 @@ int perf_evsel__parse_sample(struct perf_evsel *evsel, union perf_event *event,
 	}
 
 	if (type & PERF_SAMPLE_REGS_USER) {
-		u64 avail;
-
 		/* First u64 tells us if we have any regs in sample. */
 		OVERFLOW_CHECK_u64(array);
-		avail = *array++;
+		data->user_regs.abi = *array;
+		array++;
 
-		if (avail) {
+		if (data->user_regs.abi) {
 			u64 regs_user = evsel->attr.sample_regs_user;
 
 			sz = hweight_long(regs_user) * sizeof(u64);
-- 
1.7.11.7


  parent reply	other threads:[~2013-08-26 12:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-26 13:00 [PATCH V12 00/13] perf tools: some fixes and tweaks Adrian Hunter
2013-08-26 13:00 ` [PATCH V12 01/13] perf tools: allow non-matching sample types Adrian Hunter
2013-08-26 13:00 ` [PATCH V12 02/13] perf tools: add pid to struct thread Adrian Hunter
2013-08-29 10:10   ` [tip:perf/core] perf tools: Add " tip-bot for Adrian Hunter
2013-08-26 13:00 ` [PATCH V12 03/13] perf tools: change machine__findnew_thread() to set thread pid Adrian Hunter
2013-08-26 13:00 ` [PATCH V12 04/13] perf tools: tidy up sample parsing overflow checking Adrian Hunter
2013-08-26 13:00 ` [PATCH V12 05/13] perf tools: remove unnecessary callchain validation Adrian Hunter
2013-08-26 13:00 ` [PATCH V12 06/13] perf tools: remove references to struct ip_event Adrian Hunter
2013-08-26 13:00 ` [PATCH V12 07/13] perf: make events stream always parsable Adrian Hunter
2013-08-26 13:00 ` [PATCH V12 08/13] perf tools: move perf_evlist__config() to a new source file Adrian Hunter
2013-08-26 13:00 ` [PATCH V12 09/13] perf tools: add support for PERF_SAMPLE_IDENTFIER Adrian Hunter
2013-08-26 13:00 ` Adrian Hunter [this message]
2013-08-26 13:00 ` [PATCH V12 11/13] perf tools: expand perf_event__synthesize_sample() Adrian Hunter
2013-08-26 13:00 ` [PATCH V12 12/13] perf tools: add a function to calculate sample event size Adrian Hunter
2013-08-26 13:00 ` [PATCH V12 13/13] perf tools: add a sample parsing test Adrian Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1377522030-27870-11-git-send-email-adrian.hunter@intel.com \
    --to=adrian.hunter@intel.com \
    --cc=acme@ghostprotocols.net \
    --cc=dsahern@gmail.com \
    --cc=efault@gmx.de \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@gmail.com \
    --cc=paulus@samba.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome