From: Iker Pedrosa <ikerpedrosam@gmail.com>
To: pavel@ucw.cz
Cc: gregkh@linuxfoundation.org, ikerpedrosam@gmail.com,
justinmattock@gmail.com, harsh1kumar@gmail.com,
dan.carpenter@oracle.com, mujeeb.adil@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH 21/24] Staging: winbond: wb35tx: Replace printk with netdev_err
Date: Mon, 26 Aug 2013 17:10:20 +0200 [thread overview]
Message-ID: <1377529823-5116-22-git-send-email-ikerpedrosam@gmail.com> (raw)
In-Reply-To: <1377529823-5116-1-git-send-email-ikerpedrosam@gmail.com>
The previously used printk lacked the warning level, now we've got a more accurate way to know the error.
Signed-off-by: Iker Pedrosa <ikerpedrosam@gmail.com>
---
drivers/staging/winbond/wb35tx.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/winbond/wb35tx.c b/drivers/staging/winbond/wb35tx.c
index 8c25cbd..18b28f2 100644
--- a/drivers/staging/winbond/wb35tx.c
+++ b/drivers/staging/winbond/wb35tx.c
@@ -32,7 +32,7 @@ static void Wb35Tx_complete(struct urb *pUrb)
struct wb35_tx *pWb35Tx = &pHwData->Wb35Tx;
struct wb35_mds *pMds = &adapter->Mds;
- printk("wb35: tx complete\n");
+ netdev_err(pUrb->dev, "wb35: tx complete\n");
/* Variable setting */
pWb35Tx->EP4vm_state = VM_COMPLETED;
pWb35Tx->EP4VM_status = pUrb->status; /* Store the last result of Irp */
@@ -49,7 +49,7 @@ static void Wb35Tx_complete(struct urb *pUrb)
/* The URB is completed, check the result */
if (pWb35Tx->EP4VM_status != 0) {
- printk("URB submission failed\n");
+ netdev_err(pUrb->dev, "URB submission failed\n");
pWb35Tx->EP4vm_state = VM_STOP;
goto error;
}
@@ -96,7 +96,7 @@ static void Wb35Tx(struct wbsoft_priv *adapter)
pWb35Tx->EP4vm_state = VM_RUNNING;
retv = usb_submit_urb(pUrb, GFP_ATOMIC);
if (retv < 0) {
- printk("EP4 Tx Irp sending error\n");
+ netdev_err(pUrb->dev, "EP4 Tx Irp sending error\n");
goto cleanup;
}
@@ -218,7 +218,7 @@ static void Wb35Tx_EP2VM_complete(struct urb *pUrb)
/* The Urb is completed, check the result */
if (pWb35Tx->EP2VM_status != 0) {
- printk("EP2 IoCompleteRoutine return error\n");
+ netdev_err(pUrb->dev, "EP2 IoCompleteRoutine return error\n");
pWb35Tx->EP2vm_state = VM_STOP;
goto error;
}
--
1.8.1.2
next prev parent reply other threads:[~2013-08-26 15:11 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-26 15:09 [PATCH 00/24] Staging: winbond: Fixed some coding style issues Iker Pedrosa
2013-08-26 15:10 ` [PATCH 01/24] Staging: winbond: mto: removed function declaration Iker Pedrosa
2013-08-26 15:10 ` [PATCH 02/24] Staging: winbond: mto: avoided use of extern functions Iker Pedrosa
2013-08-26 15:10 ` [PATCH 03/24] Staging: winbond: mto: deleted " Iker Pedrosa
2013-08-26 15:10 ` [PATCH 04/24] Staging: winbond: phy_calibration: fixed some lines over 80 characters Iker Pedrosa
2013-08-26 15:10 ` [PATCH 05/24] " Iker Pedrosa
2013-08-26 16:02 ` Dan Carpenter
2013-08-26 16:50 ` Joe Perches
2013-09-05 11:45 ` Pavel Machek
2013-08-27 23:46 ` Greg KH
2013-08-26 15:10 ` [PATCH 06/24] Staging: winbond: reg: erased trailing whitespace Iker Pedrosa
2013-08-26 15:10 ` [PATCH 07/24] Staging: winbond: reg: white space deleted Iker Pedrosa
2013-08-26 15:10 ` [PATCH 08/24] Staging: winbond: reg: changed sleep function from msleep to usleep Iker Pedrosa
2013-08-27 23:38 ` Greg KH
2013-08-26 15:10 ` [PATCH 09/24] Staging: winbond: reg: fixed some lines over 80 characters Iker Pedrosa
2013-08-26 16:12 ` Dan Carpenter
2013-08-26 16:20 ` Dan Carpenter
2013-08-26 15:10 ` [PATCH 10/24] " Iker Pedrosa
2013-08-26 15:10 ` [PATCH 11/24] " Iker Pedrosa
2013-08-26 15:10 ` [PATCH 12/24] " Iker Pedrosa
2013-08-26 15:10 ` [PATCH 13/24] " Iker Pedrosa
2013-08-26 15:10 ` [PATCH 14/24] " Iker Pedrosa
2013-08-26 15:10 ` [PATCH 15/24] " Iker Pedrosa
2013-08-26 15:10 ` [PATCH 16/24] Staging: winbond: wb35reg_f: fixed " Iker Pedrosa
2013-08-26 15:10 ` [PATCH 17/24] Staging: winbond: wb35reg_s: deleted space before tabulation Iker Pedrosa
2013-08-26 15:10 ` [PATCH 18/24] Staging: winbond: wb35rx: changed sleep function from msleep to usleep Iker Pedrosa
2013-08-26 15:10 ` [PATCH 19/24] Staging: winbond: wb35rx: fixed some lines over 80 characters Iker Pedrosa
2013-08-26 15:10 ` [PATCH 20/24] Staging: winbond: wb35tx: changed sleep function from msleep to usleep Iker Pedrosa
2013-08-27 23:38 ` Greg KH
2013-08-26 15:10 ` Iker Pedrosa [this message]
2013-08-26 15:10 ` [PATCH 22/24] Staging: winbond: wb35tx_s: erased the spaces after opening a '[' Iker Pedrosa
2013-08-26 15:10 ` [PATCH 23/24] Staging: winbond: wbusb: fixed some lines over 80 characters Iker Pedrosa
2013-08-26 16:39 ` Dan Carpenter
2013-08-26 15:10 ` [PATCH 24/24] Staging: winbond: wbusb: changed sleep function from msleep to usleep Iker Pedrosa
2013-08-26 16:43 ` [PATCH 00/24] Staging: winbond: Fixed some coding style issues Dan Carpenter
2013-08-27 14:54 ` Iker Pedrosa
2013-08-30 11:55 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377529823-5116-22-git-send-email-ikerpedrosam@gmail.com \
--to=ikerpedrosam@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=harsh1kumar@gmail.com \
--cc=justinmattock@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mujeeb.adil@gmail.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®