From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752573Ab3HZVF7 (ORCPT ); Mon, 26 Aug 2013 17:05:59 -0400 Received: from perches-mx.perches.com ([206.117.179.246]:42405 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752376Ab3HZVF4 (ORCPT ); Mon, 26 Aug 2013 17:05:56 -0400 Message-ID: <1377551155.1877.18.camel@joe-AO722> Subject: Re: [PATCH RESEND V3 net-next 2/3] net: huawei_cdc_ncm: Introduce the huawei_cdc_ncm driver From: Joe Perches To: David Miller Cc: mrkiko.rs@gmail.com, gregkh@linuxfoundation.org, oliver@neukum.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org Date: Mon, 26 Aug 2013 14:05:55 -0700 In-Reply-To: <20130826.165831.112649899191508957.davem@davemloft.net> References: <1377244590-8558-3-git-send-email-mrkiko.rs@gmail.com> <20130826.163125.1134768821551948034.davem@davemloft.net> <1377549913.1877.12.camel@joe-AO722> <20130826.165831.112649899191508957.davem@davemloft.net> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.6.4-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2013-08-26 at 16:58 -0400, David Miller wrote: > From: Joe Perches > Date: Mon, 26 Aug 2013 13:45:13 -0700 > > > I think the premise of local variable > > declaration by line length is flawed. > > I disagree. > > > It can't work when local variables are > > dependent on initialization order as > > above. > > Move the initialization below the declarations. So all initializations should be on separate lines from declarations? ick. It's possible, but it doubles the associated line count and I still think it's a very dubious premise/practice/style. As a general rule, it's I suppose OK, but as a hardened rule, it's like most all hard rules. It's made to be broken.