mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Nicholas A. Bellinger" <nab@daterainc.com>
To: target-devel <target-devel@vger.kernel.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
	linux-scsi <linux-scsi@vger.kernel.org>,
	Christoph Hellwig <hch@lst.de>, Hannes Reinecke <hare@suse.de>,
	Martin Petersen <martin.petersen@oracle.com>,
	Chris Mason <chris.mason@fusionio.com>,
	Roland Dreier <roland@purestorage.com>,
	Zach Brown <zab@redhat.com>, Kent Overstreet <kmo@daterainc.com>,
	Theodore Tso <tytso@mit.edu>,
	James Bottomley <JBottomley@Parallels.com>,
	Nicholas Bellinger <nab@linux-iscsi.org>,
	Nicholas Bellinger <nab@daterainc.com>
Subject: [PATCH-v2 3/9] target: Make helpers non static for EXTENDED_COPY command setup
Date: Mon, 26 Aug 2013 22:03:02 +0000	[thread overview]
Message-ID: <1377554588-28394-4-git-send-email-nab@daterainc.com> (raw)
In-Reply-To: <1377554588-28394-1-git-send-email-nab@daterainc.com>

From: Nicholas Bellinger <nab@daterainc.com>

Both target_alloc_sgl() and transport_generic_map_mem_to_cmd() are
required by EXTENDED_COPY logic when setting up internally dispatched
command descriptors, so go ahead and make both of these non static.

Cc: Christoph Hellwig <hch@lst.de>
Cc: Hannes Reinecke <hare@suse.de>
Cc: Martin Petersen <martin.petersen@oracle.com>
Cc: Chris Mason <chris.mason@fusionio.com>
Cc: Roland Dreier <roland@purestorage.com>
Cc: Zach Brown <zab@redhat.com>
Cc: James Bottomley <JBottomley@Parallels.com>
Cc: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Nicholas Bellinger <nab@daterainc.com>
---
 drivers/target/target_core_transport.c |    4 ++--
 include/target/target_core_backend.h   |    4 ++++
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
index 526e5ba..6d0e523 100644
--- a/drivers/target/target_core_transport.c
+++ b/drivers/target/target_core_transport.c
@@ -1253,7 +1253,7 @@ int transport_handle_cdb_direct(
 }
 EXPORT_SYMBOL(transport_handle_cdb_direct);
 
-static sense_reason_t
+sense_reason_t
 transport_generic_map_mem_to_cmd(struct se_cmd *cmd, struct scatterlist *sgl,
 		u32 sgl_count, struct scatterlist *sgl_bidi, u32 sgl_bidi_count)
 {
@@ -2116,7 +2116,7 @@ void transport_kunmap_data_sg(struct se_cmd *cmd)
 }
 EXPORT_SYMBOL(transport_kunmap_data_sg);
 
-static int
+int
 target_alloc_sgl(struct scatterlist **sgl, unsigned int *nents, u32 length,
 		 bool zero_page)
 {
diff --git a/include/target/target_core_backend.h b/include/target/target_core_backend.h
index 77f25e0..5ebe21c 100644
--- a/include/target/target_core_backend.h
+++ b/include/target/target_core_backend.h
@@ -74,6 +74,10 @@ int	transport_set_vpd_ident(struct t10_vpd *, unsigned char *);
 /* core helpers also used by command snooping in pscsi */
 void	*transport_kmap_data_sg(struct se_cmd *);
 void	transport_kunmap_data_sg(struct se_cmd *);
+/* core helpers also used by xcopy during internal command setup */
+int	target_alloc_sgl(struct scatterlist **, unsigned int *, u32, bool);
+sense_reason_t	transport_generic_map_mem_to_cmd(struct se_cmd *,
+		struct scatterlist *, u32, struct scatterlist *, u32);
 
 void	array_free(void *array, int n);
 
-- 
1.7.2.5


  parent reply	other threads:[~2013-08-26 22:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-26 22:02 [PATCH-v2 0/9] target: Add support for EXTENDED_COPY (VAAI) offload emulation Nicholas A. Bellinger
2013-08-26 22:03 ` [PATCH-v2 1/9] target: Make target_core_subsystem defined as non static Nicholas A. Bellinger
2013-08-26 22:03 ` [PATCH-v2 2/9] target: Make spc_parse_naa_6h_vendor_specific " Nicholas A. Bellinger
2013-08-26 22:03 ` Nicholas A. Bellinger [this message]
2013-08-26 22:03 ` [PATCH-v2 4/9] target: Add global device list for EXTENDED_COPY Nicholas A. Bellinger
2013-08-26 22:03 ` [PATCH-v2 5/9] target: Avoid non-existent tg_pt_gp_mem in target_alua_state_check Nicholas A. Bellinger
2013-08-26 22:03 ` [PATCH-v2 6/9] target: Add support for EXTENDED_COPY copy offload emulation Nicholas A. Bellinger
2013-08-26 22:03 ` [PATCH-v2 7/9] target: Enable EXTENDED_COPY setup in spc_parse_cdb Nicholas A. Bellinger
2013-08-26 22:03 ` [PATCH-v2 8/9] target: Add Third Party Copy (3PC) bit in INQUIRY response Nicholas A. Bellinger
2013-08-26 22:03 ` [PATCH-v2 9/9] target: Enable global EXTENDED_COPY setup/release Nicholas A. Bellinger
2013-08-26 22:46 ` [PATCH-v2 0/9] target: Add support for EXTENDED_COPY (VAAI) offload emulation Zach Brown
2013-08-27  0:02   ` Nicholas A. Bellinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1377554588-28394-4-git-send-email-nab@daterainc.com \
    --to=nab@daterainc.com \
    --cc=JBottomley@Parallels.com \
    --cc=chris.mason@fusionio.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=kmo@daterainc.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=nab@linux-iscsi.org \
    --cc=roland@purestorage.com \
    --cc=target-devel@vger.kernel.org \
    --cc=tytso@mit.edu \
    --cc=zab@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®