From: Joe Perches <joe@perches.com>
To: Jason Baron <jbaron@akamai.com>
Cc: Dmitry Kasatkin <d.kasatkin@samsung.com>,
Hiroshi Doyu <hdoyu@nvidia.com>,
"sarah.a.sharp@linux.intel.com" <sarah.a.sharp@linux.intel.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"dmitry.kasatkin@gmail.com" <dmitry.kasatkin@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv2 1/2] dev-core: fix build break when DEBUG is enabled
Date: Tue, 27 Aug 2013 11:16:02 -0700 [thread overview]
Message-ID: <1377627362.6337.40.camel@joe-AO722> (raw)
In-Reply-To: <521CE2C9.1010002@akamai.com>
On Tue, 2013-08-27 at 13:32 -0400, Jason Baron wrote:
> On 08/27/2013 12:20 PM, Joe Perches wrote:
> > On Tue, 2013-08-27 at 17:47 +0300, Dmitry Kasatkin wrote:
> >> When DEBUG is defined, dev_dbg_ratelimited uses dynamic debug data
> >> structures even when CONFIG_DYNAMIC_DEBUG is not defined.
> >> It leads to build break.
> >> For example, when I try to use dev_dbg_ratelimited in USB code and
> >> CONFIG_USB_DEBUG is enabled, but CONFIG_DYNAMIC_DEBUG is not, I get:
> > Jason?
> >
> > Seems mostly sensible to me but I think the first check
> > needs to be
> >
> > #if defined(CONFIG_DYNAMIC_DEBUG) && defined(DEBUG)
>
> Why? All the other call-sites, do it the way Dmitry has done it.
Fine. Originally I thought it useful to not
store the ratelimit state, but this way those
messages can be enabled via the dynamic_debug
control.
next prev parent reply other threads:[~2013-08-27 18:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-27 14:47 Dmitry Kasatkin
2013-08-27 14:47 ` [PATCHv2 2/2] xhci:prevent "callbacks suppressed" when debug is not enabled Dmitry Kasatkin
2013-08-27 14:52 ` Dmitry Kasatkin
2013-08-27 17:55 ` Sarah Sharp
2013-08-27 16:20 ` [PATCHv2 1/2] dev-core: fix build break when DEBUG is enabled Joe Perches
2013-08-27 17:32 ` Jason Baron
2013-08-27 18:16 ` Joe Perches [this message]
2013-08-27 18:30 ` Dmitry Kasatkin
2013-08-28 17:50 ` [PATCH v3 1/1] " Sarah Sharp
2013-08-28 17:56 ` Greg KH
2013-08-28 17:43 ` [PATCHv2 1/2] " Sarah Sharp
2013-08-28 17:49 ` Dmitry Kasatkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377627362.6337.40.camel@joe-AO722 \
--to=joe@perches.com \
--cc=d.kasatkin@samsung.com \
--cc=dmitry.kasatkin@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdoyu@nvidia.com \
--cc=jbaron@akamai.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sarah.a.sharp@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®