From: Johannes Berg <johannes@sipsolutions.net>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, Huang Ying <ying.huang@intel.com>
Subject: Re: [PATCH] debugfs: provide debugfs_create_x64() when disabled
Date: Wed, 28 Aug 2013 08:39:07 +0200 [thread overview]
Message-ID: <1377671947.13797.2.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <20130828050857.GA17192@kroah.com>
On Tue, 2013-08-27 at 22:08 -0700, Greg Kroah-Hartman wrote:
> On Mon, Aug 26, 2013 at 09:58:30AM +0200, Johannes Berg wrote:
> > From: Johannes Berg <johannes.berg@intel.com>
> >
> > commit 15b0beaa332b3923cc ("Add x64 support to debugfs") added
> > debugfs_create_x64(), but forgot to provide it when debugfs is
> > disabled, causing problems when code tries to use it even then.
> > Provide the appropriate static inline.
>
> That's funny, given that it's been this way for over 3 years without
> anyone noticing :)
Heh. I only noticed because the ath9k driver was broken and selected
mac80211 debugfs without regard for DEBUG_FS configuration, and thus it
failed compile on this. This is a Kconfig bug, so I don't really need
this inline and it will never get used, but I figured debugfs has all
inlines so it should have this one as well.
johannes
prev parent reply other threads:[~2013-08-28 6:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-26 7:58 Johannes Berg
2013-08-28 5:08 ` Greg Kroah-Hartman
2013-08-28 6:39 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377671947.13797.2.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome