mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	Adrian Hunter <adrian.hunter@intel.com>,
	David Ahern <dsahern@gmail.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Jiri Olsa <jolsa@redhat.com>, Mike Galbraith <efault@gmx.de>,
	Namhyung Kim <namhyung@gmail.com>,
	Paul Mackerras <paulus@samba.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Stephane Eranian <eranian@google.com>,
	Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 08/15] perf tools: Add missing 'abi' member to 'struct regs_dump'
Date: Fri, 30 Aug 2013 15:58:51 -0300	[thread overview]
Message-ID: <1377889138-8793-9-git-send-email-acme@infradead.org> (raw)
In-Reply-To: <1377889138-8793-1-git-send-email-acme@infradead.org>

From: Adrian Hunter <adrian.hunter@intel.com>

And store the parsed value there.  Note that the 'abi' is 0 (no
registers), 1 (32-bit registers) or 2 (64-bit registers), but the
registers are anyway copied one-by-one as 64-bit values onto the event
i.e. see 'perf_output_sample_regs()'

Acked-by: Jiri Olsa <jolsa@redhat.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Namhyung Kim <namhyung@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/1377591794-30553-9-git-send-email-adrian.hunter@intel.com
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/event.h | 1 +
 tools/perf/util/evsel.c | 7 +++----
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/tools/perf/util/event.h b/tools/perf/util/event.h
index 4913339..f959801 100644
--- a/tools/perf/util/event.h
+++ b/tools/perf/util/event.h
@@ -62,6 +62,7 @@ struct sample_event {
 };
 
 struct regs_dump {
+	u64 abi;
 	u64 *regs;
 };
 
diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
index db4e431..1184188 100644
--- a/tools/perf/util/evsel.c
+++ b/tools/perf/util/evsel.c
@@ -1416,13 +1416,12 @@ int perf_evsel__parse_sample(struct perf_evsel *evsel, union perf_event *event,
 	}
 
 	if (type & PERF_SAMPLE_REGS_USER) {
-		u64 avail;
-
 		/* First u64 tells us if we have any regs in sample. */
 		OVERFLOW_CHECK_u64(array);
-		avail = *array++;
+		data->user_regs.abi = *array;
+		array++;
 
-		if (avail) {
+		if (data->user_regs.abi) {
 			u64 regs_user = evsel->attr.sample_regs_user;
 
 			sz = hweight_long(regs_user) * sizeof(u64);
-- 
1.8.1.4


  parent reply	other threads:[~2013-08-30 18:59 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-30 18:58 [GIT PULL 00/15] perf/core improvements and fixes Arnaldo Carvalho de Melo
2013-08-30 18:58 ` [PATCH 01/15] perf tools: change machine__findnew_thread() to set thread pid Arnaldo Carvalho de Melo
2013-08-30 18:58 ` [PATCH 02/15] perf evsel: Tidy up sample parsing overflow checking Arnaldo Carvalho de Melo
2013-08-30 18:58 ` [PATCH 03/15] perf callchain: Remove unnecessary validation Arnaldo Carvalho de Melo
2013-08-30 18:58 ` [PATCH 04/15] perf tools: Remove references to struct ip_event Arnaldo Carvalho de Melo
2013-08-30 18:58 ` [PATCH 05/15] perf: make events stream always parsable Arnaldo Carvalho de Melo
2013-08-30 18:58 ` [PATCH 06/15] perf evlist: Move perf_evlist__config() to a new source file Arnaldo Carvalho de Melo
2013-08-30 18:58 ` [PATCH 07/15] perf tools: Add support for PERF_SAMPLE_IDENTIFIER Arnaldo Carvalho de Melo
2013-08-30 18:58 ` Arnaldo Carvalho de Melo [this message]
2013-08-30 18:58 ` [PATCH 09/15] perf tools: Expand perf_event__synthesize_sample() Arnaldo Carvalho de Melo
2013-08-30 18:58 ` [PATCH 10/15] perf tools: Add a function to calculate sample event size Arnaldo Carvalho de Melo
2013-08-30 18:58 ` [PATCH 11/15] perf tests: Add a sample parsing test Arnaldo Carvalho de Melo
2013-08-30 18:58 ` [PATCH 12/15] perf evlist: Add tracepoint lookup by name Arnaldo Carvalho de Melo
2013-08-30 18:58 ` [PATCH 13/15] perf trace: Add option to analyze events in a file versus live Arnaldo Carvalho de Melo
2013-08-30 18:58 ` [PATCH 14/15] perf trace: Honor target pid / tid options when analyzing a file Arnaldo Carvalho de Melo
2013-08-30 18:58 ` [PATCH 15/15] perf trace: Handle missing HUGEPAGE defines Arnaldo Carvalho de Melo
2013-08-31  8:08 ` [GIT PULL 00/15] perf/core improvements and fixes Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1377889138-8793-9-git-send-email-acme@infradead.org \
    --to=acme@infradead.org \
    --cc=acme@redhat.com \
    --cc=adrian.hunter@intel.com \
    --cc=dsahern@gmail.com \
    --cc=efault@gmx.de \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@gmail.com \
    --cc=paulus@samba.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®