From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757596Ab3IAPa6 (ORCPT ); Sun, 1 Sep 2013 11:30:58 -0400 Received: from mail-pd0-f176.google.com ([209.85.192.176]:50770 "EHLO mail-pd0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753273Ab3IAPa4 (ORCPT ); Sun, 1 Sep 2013 11:30:56 -0400 From: Chenggang Qin To: linux-kernel@vger.kernel.org Cc: Chenggang Qin , David Ahern , Peter Zijlstra , Paul Mackerras , Ingo Molnar , Arnaldo Carvalho de Melo , Arjan van de Ven , Namhyung Kim , Yanmin Zhang , Wu Fengguang , Mike Galbraith , Andrew Morton Subject: [PATCH 3/3] perf core: Fix a memory leak bug because symbol__delete is ignored Date: Sun, 1 Sep 2013 23:29:45 +0800 Message-Id: <1378049385-4466-3-git-send-email-chenggang.qin@gmail.com> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: <1378049385-4466-1-git-send-email-chenggang.qin@gmail.com> References: <1378049385-4466-1-git-send-email-chenggang.qin@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chenggang Qin In function symbols__fixup_duplicate(), while the duplicated symbols are found, only the rb_node are deleted. The symbol structures themself are ignored. Then, these memory areas are lost. This patch fixed the bug. Thanks. Cc: David Ahern Cc: Peter Zijlstra Cc: Paul Mackerras Cc: Ingo Molnar Cc: Arnaldo Carvalho de Melo Cc: Arjan van de Ven Cc: Namhyung Kim Cc: Yanmin Zhang Cc: Wu Fengguang Cc: Mike Galbraith Cc: Andrew Morton Signed-off-by: Chenggang Qin --- tools/perf/util/symbol.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c index 9675866..3c9aa6f 100644 --- a/tools/perf/util/symbol.c +++ b/tools/perf/util/symbol.c @@ -148,10 +148,12 @@ again: if (choose_best_symbol(curr, next) == SYMBOL_A) { rb_erase(&next->rb_node, symbols); + symbol__delete(next); goto again; } else { nd = rb_next(&curr->rb_node); rb_erase(&curr->rb_node, symbols); + symbol__delete(curr); } } } -- 1.7.8.rc2.5.g815b