From: Tang Chen <tangchen@cn.fujitsu.com>
To: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
lenb@kernel.org, rjw@sisk.pl, liwanp@linux.vnet.ibm.com,
tj@kernel.org, akpm@linux-foundation.org, joe@perches.com,
toshi.kani@hp.com
Cc: x86@kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: [PATCH v2 3/4] acpi: Check if @id is NULL in acpi_table_parse()
Date: Tue, 3 Sep 2013 16:45:40 +0800 [thread overview]
Message-ID: <1378197941-26479-4-git-send-email-tangchen@cn.fujitsu.com> (raw)
In-Reply-To: <1378197941-26479-1-git-send-email-tangchen@cn.fujitsu.com>
strncmp() does not check if the params are NULL. In acpi_table_parse(),
if @id is NULL, the kernel will panic.
Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
Acked-by: Toshi Kani <toshi.kani@hp.com>
---
drivers/acpi/tables.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c
index d67a1fe..5a5263b 100644
--- a/drivers/acpi/tables.c
+++ b/drivers/acpi/tables.c
@@ -293,7 +293,7 @@ int __init acpi_table_parse(char *id, acpi_tbl_table_handler handler)
if (acpi_disabled)
return -ENODEV;
- if (!handler)
+ if (!id || !handler)
return -EINVAL;
if (strncmp(id, ACPI_SIG_MADT, 4) == 0)
--
1.7.1
next prev parent reply other threads:[~2013-09-03 8:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-03 8:45 [PATCH v2 0/4] acpi: Fix and cleanup in acpi Tang Chen
2013-09-03 8:45 ` [PATCH v2 1/4] acpi, numa, mem_hotplug: Kill save_add_info() Tang Chen
2013-09-03 8:45 ` [PATCH v2 2/4] acpi cleanup: Use pr_{info|err}() instead of printk() in arch/x86/mm/srat.c Tang Chen
2013-09-05 0:33 ` Yasuaki Ishimatsu
2013-09-03 8:45 ` Tang Chen [this message]
2013-09-03 8:45 ` [PATCH v2 4/4] acpi: Return -ENOENT in acpi_table_parse() and fix wrong comment Tang Chen
2013-09-04 21:39 ` Toshi Kani
2013-09-04 23:50 ` [PATCH v2 0/4] acpi: Fix and cleanup in acpi Rafael J. Wysocki
2013-09-05 1:56 ` Tang Chen
2013-09-05 11:59 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378197941-26479-4-git-send-email-tangchen@cn.fujitsu.com \
--to=tangchen@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=joe@perches.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liwanp@linux.vnet.ibm.com \
--cc=mingo@redhat.com \
--cc=rjw@sisk.pl \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=toshi.kani@hp.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®