mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jerome Oufella <jerome.oufella@savoirfairelinux.com>
To: "H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>
Cc: <x86@kernel.org>,
	linux-kernel@vger.kernel.org, Paul Bolle <pebolle@tiscali.nl>,
	kernel@savoirfairelinux.com,
	Jerome Oufella <jerome.oufella@savoirfairelinux.com>
Subject: [PATCH] x86, tsc: downgrade fast calibration failure message
Date: Tue,  3 Sep 2013 10:09:55 -0400	[thread overview]
Message-ID: <1378217395-1241-1-git-send-email-jerome.oufella@savoirfairelinux.com> (raw)

As pointed out by Paul Bolle in https://lkml.org/lkml/2012/9/24/221, the
fast TSC calibration method may fail on some machines and result in an
error level message that does not reflect the severity of the case.

Signed-off-by: Jerome Oufella <jerome.oufella@savoirfairelinux.com>
---
This patch lost momentum and wordsmithing the message was evoked in
subsequent posts but imho reducing the level does the job just fine.
---
 arch/x86/kernel/tsc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
index 6ff4924..e518724 100644
--- a/arch/x86/kernel/tsc.c
+++ b/arch/x86/kernel/tsc.c
@@ -380,7 +380,7 @@ static unsigned long quick_pit_calibrate(void)
 			goto success;
 		}
 	}
-	pr_err("Fast TSC calibration failed\n");
+	pr_info("Fast TSC calibration failed\n");
 	return 0;
 
 success:
-- 
1.8.1.4


             reply	other threads:[~2013-09-03 14:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-03 14:09 Jerome Oufella [this message]
2013-09-03 14:31 ` Paul Bolle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1378217395-1241-1-git-send-email-jerome.oufella@savoirfairelinux.com \
    --to=jerome.oufella@savoirfairelinux.com \
    --cc=hpa@zytor.com \
    --cc=kernel@savoirfairelinux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=pebolle@tiscali.nl \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®