From: Steven Whitehouse <swhiteho@redhat.com>
To: linux-kernel@vger.kernel.org, cluster-devel@redhat.com
Cc: Bob Peterson <rpeterso@redhat.com>,
Steven Whitehouse <swhiteho@redhat.com>
Subject: [PATCH 4/6] GFS2: Remove unnecessary memory barrier
Date: Thu, 5 Sep 2013 10:02:10 +0100 [thread overview]
Message-ID: <1378371732-3947-5-git-send-email-swhiteho@redhat.com> (raw)
In-Reply-To: <1378371732-3947-1-git-send-email-swhiteho@redhat.com>
From: Bob Peterson <rpeterso@redhat.com>
Function test_and_clear_bit implies a memory barrier, so subsequent
memory barriers are unnecessary.
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c
index ce7078d..722329c 100644
--- a/fs/gfs2/glock.c
+++ b/fs/gfs2/glock.c
@@ -1411,7 +1411,6 @@ __acquires(&lru_lock)
if (demote_ok(gl))
handle_callback(gl, LM_ST_UNLOCKED, 0, false);
WARN_ON(!test_and_clear_bit(GLF_LOCK, &gl->gl_flags));
- smp_mb__after_clear_bit();
if (queue_delayed_work(glock_workqueue, &gl->gl_work, 0) == 0)
gfs2_glock_put_nolock(gl);
spin_unlock(&gl->gl_spin);
--
1.7.4
next prev parent reply other threads:[~2013-09-05 9:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-05 9:02 GFS2 Pre-pull patch posting (merge window) Steven Whitehouse
2013-09-05 9:02 ` [PATCH 1/6] GFS2: Move gfs2_sync_meta to lops.c Steven Whitehouse
2013-09-05 9:02 ` [PATCH 2/6] GFS2: Take glock reference in examine_bucket() Steven Whitehouse
2013-09-05 9:02 ` [PATCH 3/6] GFS2: Merge ordered and writeback writepage Steven Whitehouse
2013-09-05 9:02 ` Steven Whitehouse [this message]
2013-09-05 9:02 ` [PATCH 5/6] GFS2: Don't flag consistency error if first mounter is a spectator Steven Whitehouse
2013-09-05 9:02 ` [PATCH 6/6] GFS2: dirty inode correctly in gfs2_write_end Steven Whitehouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378371732-3947-5-git-send-email-swhiteho@redhat.com \
--to=swhiteho@redhat.com \
--cc=cluster-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rpeterso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®