From: minyard@acm.org
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
OpenIPMI Developers <openipmi-developer@lists.sourceforge.net>,
Dan Carpenter <dan.carpenter@oracle.com>,
Corey Minyard <cminyard@mvista.com>
Subject: [PATCH 1/4] ipmi: info leak in compat_ipmi_ioctl()
Date: Thu, 05 Sep 2013 06:36:33 -0500 [thread overview]
Message-ID: <1378380996-4844-2-git-send-email-minyard@acm.org> (raw)
In-Reply-To: <1378380996-4844-1-git-send-email-minyard@acm.org>
From: Dan Carpenter <dan.carpenter@oracle.com>
On x86_64 there is a 4 byte hole between ->recv_type and ->addr.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
---
drivers/char/ipmi/ipmi_devintf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/char/ipmi/ipmi_devintf.c b/drivers/char/ipmi/ipmi_devintf.c
index d5a5f02..ec318bf 100644
--- a/drivers/char/ipmi/ipmi_devintf.c
+++ b/drivers/char/ipmi/ipmi_devintf.c
@@ -810,6 +810,7 @@ static long compat_ipmi_ioctl(struct file *filep, unsigned int cmd,
struct ipmi_recv __user *precv64;
struct ipmi_recv recv64;
+ memset(&recv64, 0, sizeof(recv64));
if (get_compat_ipmi_recv(&recv64, compat_ptr(arg)))
return -EFAULT;
--
1.7.9.5
next prev parent reply other threads:[~2013-09-05 11:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-05 11:36 [PATCH 0/4] Some minor IPMI fixes (with signoffs) minyard
2013-09-05 11:36 ` minyard [this message]
2013-09-05 11:36 ` [PATCH 2/4] ipmi: Initialize locals to avoid warning minyard
2013-09-05 11:36 ` [PATCH 3/4] Add MODULE_ALIAS for autoloading ipmi driver on ACPI systems minyard
2013-09-05 11:36 ` [PATCH 4/4] BMC support for PARISC machines minyard
-- strict thread matches above, loose matches on Subject: below --
2013-09-04 14:40 [PATCH 0/4] Some minor IPMI fixes minyard
2013-09-04 14:40 ` [PATCH 1/4] ipmi: info leak in compat_ipmi_ioctl() minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378380996-4844-2-git-send-email-minyard@acm.org \
--to=minyard@acm.org \
--cc=cminyard@mvista.com \
--cc=dan.carpenter@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®