mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Phillip Lougher <phillip@squashfs.org.uk>
To: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Cc: Phillip Lougher <phillip@squashfs.org.uk>
Subject: [PATCH 0/5] Squashfs: extra sanity checks and sanity check fixes
Date: Fri,  6 Sep 2013 04:54:36 +0100	[thread overview]
Message-ID: <1378439682-12830-1-git-send-email-phillip@squashfs.org.uk> (raw)

Hi,

Following on from the "Squashfs: sanity check information from disk"
patch from Dan Carpenter, I have added a couple more sanity checks,
and fixed a couple of existing sanity checks (including the patch from
Dan Carpenter).

These sanity checks mainly exist to trap maliciously corrupted
filesystems either through using a deliberately modified mksquashfs,
or where the user has deliberately chosen to generate uncompressed
metadata and then corrupted it.

Normally metadata in Squashfs filesystems is compressed, which means
corruption (either accidental or malicious) is detected when
trying to decompress the metadata.  So corrupted data does not normally
get as far as the code paths in question here.

Phillip Lougher (5):
  Squashfs: fix corruption check in get_dir_index_using_name()
  Squashfs: fix corruption checks in squashfs_lookup()
  Squashfs: fix corruption checks in squashfs_readdir()
  Squashfs: add corruption check in get_dir_index_using_offset()
  Squashfs: add corruption check for type in squashfs_readdir()

 fs/squashfs/dir.c         | 17 +++++++++++++----
 fs/squashfs/namei.c       |  7 +++----
 fs/squashfs/squashfs_fs.h |  5 ++++-
 3 files changed, 20 insertions(+), 9 deletions(-)

-- 
1.8.3.2


             reply	other threads:[~2013-09-06  4:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-06  3:54 Phillip Lougher [this message]
2013-09-06  3:54 ` [PATCH 1/5] Squashfs: fix corruption check in get_dir_index_using_name() Phillip Lougher
2013-09-06  3:54 ` [PATCH 2/5] Squashfs: fix corruption checks in squashfs_lookup() Phillip Lougher
2013-09-06  3:54 ` [PATCH 3/5] Squashfs: fix corruption checks in squashfs_readdir() Phillip Lougher
2013-09-06  3:54 ` [PATCH 4/5] Squashfs: add corruption check in get_dir_index_using_offset() Phillip Lougher
2013-09-06  3:54 ` [PATCH 5/5] Squashfs: add corruption check for type in squashfs_readdir() Phillip Lougher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1378439682-12830-1-git-send-email-phillip@squashfs.org.uk \
    --to=phillip@squashfs.org.uk \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®