From: Tom Gundersen <teg@jklm.no>
To: x86@kernel.org
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com,
tglx@linutronix.de, Tom Gundersen <teg@jklm.no>,
David Herrmann <dh.herrmann@gmail.com>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: [PATCH] x86: simplefb: avoid overflow
Date: Fri, 6 Sep 2013 11:32:13 +0200 [thread overview]
Message-ID: <1378459933-367-1-git-send-email-teg@jklm.no> (raw)
lfb_size can easily be say 4M, which would make the bitshit overflow and
the test fail.
Signed-off-by: Tom Gundersen <teg@jklm.no>
Cc: David Herrmann <dh.herrmann@gmail.com>
Cc: H. Peter Anvin <hpa@zytor.com>
---
arch/x86/kernel/sysfb_simplefb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/sysfb_simplefb.c b/arch/x86/kernel/sysfb_simplefb.c
index 22513e9..fff44a5 100644
--- a/arch/x86/kernel/sysfb_simplefb.c
+++ b/arch/x86/kernel/sysfb_simplefb.c
@@ -72,7 +72,7 @@ __init int create_simplefb(const struct screen_info *si,
* the part that is occupied by the framebuffer */
len = mode->height * mode->stride;
len = PAGE_ALIGN(len);
- if (len > si->lfb_size << 16) {
+ if (len > ((unsigned long) si->lfb_size) << 16) {
printk(KERN_WARNING "sysfb: VRAM smaller than advertised\n");
return -EINVAL;
}
--
1.8.4
next reply other threads:[~2013-09-06 9:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-06 9:32 Tom Gundersen [this message]
2013-09-06 9:55 ` David Herrmann
2013-09-06 10:59 ` Geert Uytterhoeven
2013-09-06 11:08 ` H. Peter Anvin
2013-09-06 11:15 ` Geert Uytterhoeven
2013-09-06 11:24 ` David Herrmann
2013-09-06 11:57 ` Tom Gundersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378459933-367-1-git-send-email-teg@jklm.no \
--to=teg@jklm.no \
--cc=dh.herrmann@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®