From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Krystian Garbaciak <krystian.garbaciak@diasemi.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org, Geert Uytterhoeven <geert@linux-m68k.org>
Subject: [PATCH 2/2] regulator: da9063: Add missing initialization of da9063_reg_matches
Date: Mon, 9 Sep 2013 13:49:27 +0200 [thread overview]
Message-ID: <1378727367-8941-2-git-send-email-geert@linux-m68k.org> (raw)
In-Reply-To: <1378727367-8941-1-git-send-email-geert@linux-m68k.org>
With gcc 4.1.2:
drivers/regulator/da9063-regulator.c: In function ‘da9063_regulator_probe’:
drivers/regulator/da9063-regulator.c:847: warning: ‘da9063_reg_matches’ is used
uninitialized in this function
If the parent device already has platform data, da9063_reg_matches will
not be initialized.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
Can this happen? Or will any of the b*_merged flags be set in this case, so
the while loop continues and we never get to the place where
da9063_reg_matches is used? The code is too convoluted for me to see...
drivers/regulator/da9063-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/da9063-regulator.c b/drivers/regulator/da9063-regulator.c
index b9f2653..3d910f4 100644
--- a/drivers/regulator/da9063-regulator.c
+++ b/drivers/regulator/da9063-regulator.c
@@ -717,7 +717,7 @@ static int da9063_regulator_probe(struct platform_device *pdev)
{
struct da9063 *da9063 = dev_get_drvdata(pdev->dev.parent);
struct da9063_pdata *da9063_pdata = dev_get_platdata(da9063->dev);
- struct of_regulator_match *da9063_reg_matches;
+ struct of_regulator_match *da9063_reg_matches = NULL;
struct da9063_regulators_pdata *regl_pdata;
const struct da9063_dev_model *model;
struct da9063_regulators *regulators;
--
1.7.9.5
next prev parent reply other threads:[~2013-09-09 11:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-09 11:49 [PATCH 1/2] regulator: da9063: Fix PTR_ERR/ERR_PTR mismatch Geert Uytterhoeven
2013-09-09 11:49 ` Geert Uytterhoeven [this message]
2013-09-10 17:12 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378727367-8941-2-git-send-email-geert@linux-m68k.org \
--to=geert@linux-m68k.org \
--cc=broonie@kernel.org \
--cc=krystian.garbaciak@diasemi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®