From: Yijing Wang <wangyijing@huawei.com>
To: Bjorn Helgaas <bhelgaas@google.com>,
Chris Metcalf <cmetcalf@tilera.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
David Airlie <airlied@linux.ie>,
Mike Marciniszyn <infinipath@intel.com>,
Roland Dreier <roland@kernel.org>,
Roland Dreier <roland@purestorage.com>
Cc: <linux-kernel@vger.kernel.org>, Mark Einon <mark.einon@gmail.com>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
<linux-rdma@vger.kernel.org>, <linux-pci@vger.kernel.org>,
Yijing Wang <wangyijing@huawei.com>,
Hanjun Guo <guohanjun@huawei.com>
Subject: [PATCH 3/6] IB/qib: Use pci_is_root_bus() to check whether it is a root bus
Date: Mon, 9 Sep 2013 21:13:05 +0800 [thread overview]
Message-ID: <1378732388-4508-4-git-send-email-wangyijing@huawei.com> (raw)
In-Reply-To: <1378732388-4508-1-git-send-email-wangyijing@huawei.com>
Use pci_is_root_bus() instead of "if (bus->parent)" statement
for better readability.
Signed-off-by: Yijing Wang <wangyijing@huawei.com>
---
drivers/infiniband/hw/qib/qib_pcie.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/infiniband/hw/qib/qib_pcie.c b/drivers/infiniband/hw/qib/qib_pcie.c
index c574ec7..3a5b99b 100644
--- a/drivers/infiniband/hw/qib/qib_pcie.c
+++ b/drivers/infiniband/hw/qib/qib_pcie.c
@@ -590,7 +590,7 @@ static int qib_tune_pcie_caps(struct qib_devdata *dd)
/* Find out supported and configured values for parent (root) */
parent = dd->pcidev->bus->self;
- if (parent->bus->parent) {
+ if (!pci_is_root_bus(parent->bus)) {
qib_devinfo(dd->pcidev, "Parent not root\n");
goto bail;
}
--
1.7.1
next prev parent reply other threads:[~2013-09-09 13:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-09 13:13 [PATCH 0/6] Simplify some mps and mrrs setting related code Yijing Wang
2013-09-09 13:13 ` [PATCH 1/6] PCI: Export pcie_set_mps() and pcie_get_mps() Yijing Wang
2013-09-09 13:13 ` [PATCH 2/6] title/pci: use cached pci_dev->pcie_mpss to simplify code Yijing Wang
2013-09-09 13:13 ` Yijing Wang [this message]
2013-09-09 14:51 ` [PATCH 3/6] IB/qib: Use pci_is_root_bus() to check whether it is a root bus Marciniszyn, Mike
2013-09-09 13:13 ` [PATCH 4/6] IB/qib: Use pcie_set_mps() and pcie_get_mps() to simplify code Yijing Wang
2013-09-09 14:55 ` Marciniszyn, Mike
2013-09-10 1:04 ` Yijing Wang
2013-09-24 20:38 ` Bjorn Helgaas
2013-09-30 14:56 ` Marciniszyn, Mike
2013-10-04 20:49 ` Bjorn Helgaas
2013-09-24 20:39 ` Bjorn Helgaas
2013-10-04 20:51 ` Bjorn Helgaas
2013-09-09 13:13 ` [PATCH 5/6] staging/et131x: Use cached pci_dev->pcie_mpss and pcie_set_readrq() to simplif code Yijing Wang
2013-09-09 15:19 ` Greg Kroah-Hartman
2013-09-10 12:53 ` Mark Einon
2013-09-09 13:13 ` [PATCH 6/6] radeon: Use pcie_get_readrq() and pcie_set_readrq() to simplify code Yijing Wang
2013-10-04 20:44 ` Bjorn Helgaas
2013-10-07 12:15 ` Deucher, Alexander
2013-10-07 18:30 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378732388-4508-4-git-send-email-wangyijing@huawei.com \
--to=wangyijing@huawei.com \
--cc=airlied@linux.ie \
--cc=bhelgaas@google.com \
--cc=cmetcalf@tilera.com \
--cc=gregkh@linuxfoundation.org \
--cc=guohanjun@huawei.com \
--cc=hal.rosenstock@gmail.com \
--cc=infinipath@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mark.einon@gmail.com \
--cc=roland@kernel.org \
--cc=roland@purestorage.com \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®