From: Joe Perches <joe@perches.com>
To: "Winkler, Tomas" <tomas.winkler@intel.com>
Cc: Adam Jackson <ajax@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mei: Don't dev_err() on suspend
Date: Tue, 10 Sep 2013 09:47:24 -0700 [thread overview]
Message-ID: <1378831644.15812.13.camel@joe-AO722> (raw)
In-Reply-To: <5B8DA87D05A7694D9FA63FD143655C1B1AEC1D72@HASMSX106.ger.corp.intel.com>
On Tue, 2013-09-10 at 16:37 +0000, Winkler, Tomas wrote:
> From: Joe Perches [mailto:joe@perches.com]
> > On Tue, 2013-09-10 at 11:54 -0400, Adam Jackson wrote:
> > > Suspend isn't an error condition, and I'm sick of seeing this (and only
> > > this) on the console when I suspend with quiet boot enabled.
> > []
> > > diff --git a/drivers/misc/mei/pci-me.c b/drivers/misc/mei/pci-me.c
> > []
> > > @@ -262,7 +262,7 @@ static int mei_me_pci_suspend(struct device *device)
> > > if (!dev)
> > > return -ENODEV;
> > >
> > > - dev_err(&pdev->dev, "suspend\n");
> > > + dev_info(&pdev->dev, "suspend\n");
> >
> > dev_dbg instead?
>
> Yes, but I believe we fixed that long ago were do you see this?
drivers/misc/mei/pci-me.c of both linus and -next
prev parent reply other threads:[~2013-09-10 16:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-10 15:54 Adam Jackson
2013-09-10 16:06 ` Joe Perches
2013-09-10 16:37 ` Winkler, Tomas
2013-09-10 16:47 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378831644.15812.13.camel@joe-AO722 \
--to=joe@perches.com \
--cc=ajax@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®