From: Tom Gundersen <teg@jklm.no>
To: linux-usb@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org,
Tom Gundersen <teg@jklm.no>,
Alan Stern <stern@rowland.harvard.edu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: [PATCH v2] usb: ohci/uhci - add soft dependencies on ehci_pci
Date: Tue, 10 Sep 2013 23:30:14 +0200 [thread overview]
Message-ID: <1378848614-964-1-git-send-email-teg@jklm.no> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1309101326530.1075-100000@iolanthe.rowland.org>
Support for specifying soft dependencies in the modules themselves was
introduced in commit 7cb14ba.
In Arch we have always been shipping a module.d(5) fragment ordering ohci/uhci
after ehci. If this ordering is really necessary, it would be great to move it
to the kernel and getting the correct fragment generated by depmod.
Signed-off-by: Tom Gundersen <teg@jklm.no>
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
v2: change the dependencies to *_pci, as suggested by Alan
drivers/usb/host/ohci-pci.c | 1 +
drivers/usb/host/uhci-pci.c | 2 ++
2 files changed, 3 insertions(+)
diff --git a/drivers/usb/host/ohci-pci.c b/drivers/usb/host/ohci-pci.c
index ec337c2..eedf97c 100644
--- a/drivers/usb/host/ohci-pci.c
+++ b/drivers/usb/host/ohci-pci.c
@@ -323,3 +323,4 @@ module_exit(ohci_pci_cleanup);
MODULE_DESCRIPTION(DRIVER_DESC);
MODULE_LICENSE("GPL");
+MODULE_SOFTDEP("pre: ehci_pci");
diff --git a/drivers/usb/host/uhci-pci.c b/drivers/usb/host/uhci-pci.c
index c300bd2f7..f7bbf43 100644
--- a/drivers/usb/host/uhci-pci.c
+++ b/drivers/usb/host/uhci-pci.c
@@ -299,3 +299,5 @@ static struct pci_driver uhci_pci_driver = {
},
#endif
};
+
+MODULE_SOFTDEP("pre: ehci_pci");
--
1.8.4
next prev parent reply other threads:[~2013-09-10 21:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-10 16:37 [PATCH] usb: ohci/uhci - add soft dependencies on ehci_hcd Tom Gundersen
2013-09-10 17:02 ` Alan Stern
2013-09-10 17:07 ` Kay Sievers
2013-09-10 17:12 ` Tom Gundersen
2013-09-10 17:31 ` Alan Stern
2013-09-10 21:27 ` Tom Gundersen
2013-09-10 22:48 ` Lucas De Marchi
2013-09-11 14:29 ` Alan Stern
2013-09-10 21:30 ` Tom Gundersen [this message]
2013-09-10 22:06 ` [PATCH v2] usb: ohci/uhci - add soft dependencies on ehci_pci Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378848614-964-1-git-send-email-teg@jklm.no \
--to=teg@jklm.no \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®