mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: "Miller, Mike (OS Dev)" <Mike.Miller@hp.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	LKML-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 1/4] hpsa: add HP Smart Array Gen9 PCI ID's
Date: Tue, 10 Sep 2013 15:29:49 -0700	[thread overview]
Message-ID: <1378852189.23501.54.camel@dabdike.int.hansenpartnership.com> (raw)
In-Reply-To: <48275AD710FCA34184C2B6186B4016B32D0FCEED@G6W2491.americas.hpqcorp.net>

On Tue, 2013-09-10 at 22:17 +0000, Miller, Mike (OS Dev) wrote:
> 
> -----Original Message-----
> From: James Bottomley [mailto:James.Bottomley@HansenPartnership.com] 
> Sent: Tuesday, September 10, 2013 5:02 PM
> To: Miller, Mike (OS Dev)
> Cc: Andrew Morton; LKML; LKML-scsi
> Subject: Re: [PATCH 1/4] hpsa: add HP Smart Array Gen9 PCI ID's
> 
> On Wed, 2013-09-04 at 15:05 -0500, Mike Miller wrote:
> > Patch 1 of 4
> > 
> > From: Mike Miller <mike.miller@hp.com>
> 
> Just for future reference, doing it this way means I have to edit the patch.  The way git am works when applying patches is that if the first body line is a keyword it recognises (like From: or Subject: or Date:) it will fold that into the commit metadata, otherwise everything becomes the commit message.  So by putting the redundant "patch 1 of 4" first, git thinks the entire body is the commit message.
> 
> James
> 
> Sorry about that. I didn't realize git worked that way. So let me ask
> a dumb question, just having [PATCH x/y] in the subject line is
> enough?

Yes, that's what all the apply scripts go by.

>  Would you like me to resubmit the patchset?

No; I just edited the messages this time.

James



      reply	other threads:[~2013-09-10 22:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-04 20:05 Mike Miller
2013-09-10 22:02 ` James Bottomley
2013-09-10 22:17   ` Miller, Mike (OS Dev)
2013-09-10 22:29     ` James Bottomley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1378852189.23501.54.camel@dabdike.int.hansenpartnership.com \
    --to=james.bottomley@hansenpartnership.com \
    --cc=Mike.Miller@hp.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®