From: Joe Perches <joe@perches.com>
To: Torsten Duwe <duwe@lst.de>
Cc: tytso@mit.edu, ingo.tuchscherer@de.ibm.com,
linux-kernel@vger.kernel.org,
Hans-Georg Markgraf <MGRF@de.ibm.com>,
Gerald Schaefer <GERALDSC@de.ibm.com>,
Martin Schwidefsky <martin.schwidefsky@de.ibm.com>
Subject: Re: Resend: [PATCH 2/2] s390: provide hardware randomness from zcrypt card to /dev/random
Date: Tue, 10 Sep 2013 17:39:34 -0700 [thread overview]
Message-ID: <1378859974.15187.5.camel@joe-AO722> (raw)
In-Reply-To: <alpine.LNX.2.00.1309041044470.3219@linux.site>
On Wed, 2013-09-04 at 10:48 +0200, Torsten Duwe wrote:
[]
> +++ b/drivers/s390/crypto/zcrypt_api.c
> @@ -1141,6 +1144,36 @@ static struct hwrng zcrypt_rng_dev = {
][
> +static int zcrypt_hwrng_fillfn(void *unused)
> +{
> + long rc;
> +
> + while (!kthread_should_stop()) {
> + rc = zcrypt_rng((char *)zcrypt_rng_buffer);
> + if (rc == -ENODEV || rc == -EINVAL || rc == -ENOMEM) {
> + pr_err("zcrypt_rng unavailable: %ld", rc);
please add terminating newlines
pr_err("zcrypt_rng unavailable: %ld\n", rc);
etc...
prev parent reply other threads:[~2013-09-11 0:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-04 8:48 Torsten Duwe
2013-09-11 0:39 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378859974.15187.5.camel@joe-AO722 \
--to=joe@perches.com \
--cc=GERALDSC@de.ibm.com \
--cc=MGRF@de.ibm.com \
--cc=duwe@lst.de \
--cc=ingo.tuchscherer@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.schwidefsky@de.ibm.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®