From: Ben Hutchings <bhutchings@solarflare.com>
To: ZHAO Gang <gamerh2o@gmail.com>
Cc: <davem@davemloft.net>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] [Trivial] remove unnecessary header file inclusion
Date: Fri, 13 Sep 2013 17:11:27 +0100 [thread overview]
Message-ID: <1379088687.2438.13.camel@bwh-desktop.uk.level5networks.com> (raw)
In-Reply-To: <20130913145718.GA2536@will>
On Fri, 2013-09-13 at 22:57 +0800, ZHAO Gang wrote:
> file linux/fib_rules.h doesn't exist, so remove it.
Do you think people wouldn't notice #include of a nonexistent file? gcc
is quite good at complaining about them...
It's now called include/uapi/linux/fib_rules.h.
Ben.
> Signed-off-by: ZHAO Gang <gamerh2o@gmail.com>
> ---
> include/net/fib_rules.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/net/fib_rules.h b/include/net/fib_rules.h
> index 4b2b557..c816f91 100644
> --- a/include/net/fib_rules.h
> +++ b/include/net/fib_rules.h
> @@ -4,7 +4,6 @@
> #include <linux/types.h>
> #include <linux/slab.h>
> #include <linux/netdevice.h>
> -#include <linux/fib_rules.h>
> #include <net/flow.h>
> #include <net/rtnetlink.h>
>
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2013-09-13 16:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-13 14:57 ZHAO Gang
2013-09-13 16:11 ` Ben Hutchings [this message]
2013-09-13 21:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1379088687.2438.13.camel@bwh-desktop.uk.level5networks.com \
--to=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=gamerh2o@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®