From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752318Ab3IRPo6 (ORCPT ); Wed, 18 Sep 2013 11:44:58 -0400 Received: from webmail.solarflare.com ([12.187.104.25]:13457 "EHLO webmail.solarflare.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751761Ab3IRPo5 (ORCPT ); Wed, 18 Sep 2013 11:44:57 -0400 Message-ID: <1379519092.1522.27.camel@bwh-desktop.uk.level5networks.com> Subject: Re: [PATCH 005/007] WAN Drivers: Update farsync driver and introduce fsflex driver From: Ben Hutchings To: Kevin Curtis CC: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kernel-janitors@vger.kernel.org" , "Dermot Smith" Date: Wed, 18 Sep 2013 16:44:52 +0100 In-Reply-To: References: Organization: Solarflare Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.6.4 (3.6.4-3.fc18) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.17.20.137] X-TM-AS-Product-Ver: SMEX-10.0.0.1412-7.000.1014-20158.002 X-TM-AS-Result: No--18.304500-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2013-09-18 at 11:12 +0100, Kevin Curtis wrote: > Farsite Communications FarSync driver update > > Patch 5 of 7 > Note that this patch must be applied with patch 4 (farsync_include_patch) > > Update the current farsync driver to support all of the PCI and PCI X > cards manufactured by Farsite Communications. > > Add a tty interface so that the ports can also be used by the ppp daemon. > > Add support for big endian systems (the FarSite cards have a little endian > processor on board). [...] Should all be separate patches. This is just doing way too much in one go. And there are regressions in here like: > static struct pci_driver fst_driver = { > - .name = FST_NAME, > - .id_table = fst_pci_dev_id, > - .probe = fst_add_one, > - .remove = fst_remove_one, > - .suspend = NULL, > - .resume = NULL, > +name: FST_NAME, > +id_table : fst_pci_dev_id, > +probe : fst_add_one, > +remove : fst_remove_one, > +suspend : NULL, > +resume : NULL, > +}; And the addition of a file in procfs (at the top level, even!) as if it's still 2001 and sysfs doesn't exist: > +static int farsync_proc_open(struct inode *inode, struct file *file) > +{ > + return single_open(file, fst_proc_info, NULL); > +} > + > +static const struct file_operations farsync_proc_fops = { > + .open = farsync_proc_open, > + .read = seq_read, > + .llseek = seq_lseek, > + .release = single_release, > }; Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.